Skip to content

Commit 5593185

Browse files
authored
Merge pull request #310 from GetStream/illegal-invocation-fix
Illegal invocation fix
2 parents 9aab7b7 + e45d411 commit 5593185

File tree

5 files changed

+17
-10
lines changed

5 files changed

+17
-10
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
"@types/linkifyjs": "^2.1.3",
123123
"@types/url-parse": "^1.4.3",
124124
"@types/webscopeio__react-textarea-autocomplete": "^4.7.0",
125-
"@webscopeio/react-textarea-autocomplete": "^4.7.3",
125+
"@webscopeio/react-textarea-autocomplete": "^4.8.1",
126126
"classnames": "^2.3.1",
127127
"dayjs": "^1.10.4",
128128
"emoji-mart": "^3.0.1",

src/components/CommentField.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export const CommentField = <UT extends DefaultUT = DefaultUT, AT extends Defaul
8484
rows={1}
8585
value={text}
8686
placeholder={placeholder ?? t('Start Typing...')}
87-
onChange={(event) => setText((pv) => inputValueFromEvent<HTMLTextAreaElement>(event) ?? pv)}
87+
onChange={(event) => setText((pv) => inputValueFromEvent<HTMLTextAreaElement>(event, true) ?? pv)}
8888
emojiData={emojiData}
8989
trigger={trigger}
9090
maxLength={280}

src/components/StatusUpdateForm/useStatusUpdateForm.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ export function useStatusUpdateForm<
482482
};
483483

484484
const onChange = useCallback((event: SyntheticEvent<HTMLTextAreaElement>) => {
485-
const text = inputValueFromEvent(event);
485+
const text = inputValueFromEvent(event, true);
486486
if (text === null || text === undefined) return;
487487
setText(text);
488488
handleOgDebounced(text);

src/utils/index.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,17 @@ export async function dataTransferItemsToFiles(items?: DataTransferItemList) {
136136
}
137137

138138
export function inputValueFromEvent<T extends HTMLInputElement | HTMLTextAreaElement = HTMLInputElement>(
139-
event?: React.SyntheticEvent<T>,
139+
event: React.SyntheticEvent<T> | undefined = undefined,
140+
targetFirst: boolean | undefined = false,
140141
) {
141-
const target = (event?.currentTarget || event?.target) as T;
142-
return target?.value;
142+
try {
143+
const target = (event?.[targetFirst ? 'target' : 'currentTarget'] ??
144+
event?.[targetFirst ? 'currentTarget' : 'target']) as T;
145+
return target?.value;
146+
} catch (error) {
147+
console.error(error);
148+
return undefined;
149+
}
143150
}
144151

145152
export function sanitizeURL(url?: string) {

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3191,10 +3191,10 @@
31913191
"@webassemblyjs/wast-parser" "1.9.0"
31923192
"@xtuc/long" "4.2.2"
31933193

3194-
"@webscopeio/react-textarea-autocomplete@^4.7.3":
3195-
version "4.7.3"
3196-
resolved "https://registry.yarnpkg.com/@webscopeio/react-textarea-autocomplete/-/react-textarea-autocomplete-4.7.3.tgz#48909621ca754d36a997359f8d9ff13513863fe1"
3197-
integrity sha512-Bdpl6/J+lI3cxTXJ+NsVj4D4A8Guy7t1FWtMZQLH46F63VHGCcBTGeZfnxlNEHns0FqHV8DTnHcJUeN2N4h82g==
3194+
"@webscopeio/react-textarea-autocomplete@^4.8.1":
3195+
version "4.8.1"
3196+
resolved "https://registry.yarnpkg.com/@webscopeio/react-textarea-autocomplete/-/react-textarea-autocomplete-4.8.1.tgz#2209da4337135612b33b333aabe002fb14f88aaa"
3197+
integrity sha512-1toVv6rlvpzH5pgvkfuGRFTkYrhc+flLGMjQHpnkaaVBRp+7DCgGt2ou5NdHI52PBOdQtK6Pwar5coyF33Tj/Q==
31983198
dependencies:
31993199
custom-event "^1.0.1"
32003200
textarea-caret "3.0.2"

0 commit comments

Comments
 (0)