-
Notifications
You must be signed in to change notification settings - Fork 0
Update dependencies #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomusdrw
wants to merge
14
commits into
main
Choose a base branch
from
td-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update dependencies #133
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
12506ad
build(deps-dev): bump eslint-plugin-react-hooks from 5.2.0 to 7.0.1
dependabot[bot] 24936a0
build(deps-dev): bump @vitest/coverage-v8 from 3.2.4 to 4.0.8
dependabot[bot] 9f60b37
build(deps-dev): bump globals from 16.4.0 to 16.5.0
dependabot[bot] 7d8c471
build(deps): bump zod from 4.1.11 to 4.1.12
dependabot[bot] 8e9b494
build(deps-dev): bump jsdom from 26.1.0 to 27.1.0
dependabot[bot] cf64152
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/eslint-p…
tomusdrw c98c062
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/vitest/c…
tomusdrw 1c4858b
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/globals-…
tomusdrw 2c93b32
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/zod-4.1.…
tomusdrw 4ebd367
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/jsdom-27…
tomusdrw a99a109
Bumps typeberry stuff.
tomusdrw 74230db
Lazy load examples.
tomusdrw 119677d
Update
tomusdrw 8882a8d
Fix tests.
tomusdrw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Refactor to avoid state synchronization in effect.
Setting state inside
useEffectto mirror derived values is an anti-pattern. The lint suppression masks a design issue rather than a legitimate exception.Consider these alternatives:
serviceIdsInputstate and compute the display value fromdiscoveredServiceIdsin the render phase.discoveredServiceIdschanges, triggering a re-mount with fresh initial state.Apply this diff to derive the value directly:
const discoveredServiceIds = useMemo(() => { return extractServiceIdsFromState(state); }, [state]); - const [serviceIdsInput, setServiceIdsInput] = useState(() => { - return discoveredServiceIds.length > 0 ? discoveredServiceIds.map(formatServiceIdUnsigned).join(', ') : '0'; - }); - - useEffect(() => { - if (discoveredServiceIds.length > 0) { - // eslint-disable-next-line react-hooks/set-state-in-effect - setServiceIdsInput(discoveredServiceIds.map(formatServiceIdUnsigned).join(', ')); - } - }, [discoveredServiceIds]); + const defaultServiceIdsInput = useMemo(() => { + return discoveredServiceIds.length > 0 ? discoveredServiceIds.map(formatServiceIdUnsigned).join(', ') : '0'; + }, [discoveredServiceIds]); + + const [serviceIdsInput, setServiceIdsInput] = useState(defaultServiceIdsInput); const serviceIds = useMemo(() => { return parseServiceIds(serviceIdsInput); }, [serviceIdsInput]);If the input needs to reset when
statechanges, add a key to force remount:🤖 Prompt for AI Agents