From 82c2ea88d5b729f27f521f00385a4b1b8dd10c2a Mon Sep 17 00:00:00 2001 From: Christian Braun Date: Tue, 15 Oct 2024 14:57:57 +0200 Subject: [PATCH 1/2] Patch: added redis-authentication ability --- Classes/Core/Infrastructure/RedisClientManager.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/Core/Infrastructure/RedisClientManager.php b/Classes/Core/Infrastructure/RedisClientManager.php index 6b8d1a5..b7ea966 100644 --- a/Classes/Core/Infrastructure/RedisClientManager.php +++ b/Classes/Core/Infrastructure/RedisClientManager.php @@ -32,7 +32,7 @@ protected function connect(RedisInstanceIdentifier $redisInstanceIdentifier): \R $redis = new \Redis(); $connected = false; try { - $connected = $redis->connect($instanceConfig['hostname'], $instanceConfig['port'] ?? 6379, $instanceConfig['timeout'] ?? 0) && $redis->select($instanceConfig['database'] ?? 0); + $connected = $redis->connect($instanceConfig['hostname'], $instanceConfig['port'] ?? 6379, $instanceConfig['timeout'] ?? 0) && $redis->auth([$instanceConfig['username'] ?? "default", $instanceConfig['password'] ?? ""]) && $redis->select($instanceConfig['database'] ?? 0); } catch (\Exception $e) { throw new Exception(sprintf('Could not connect to Redis server %s:%d. Detailed reason: see nested exception.', $instanceConfig['hostname'], $instanceConfig['port']), 1630323312, $e); } From 28dfd9ca420c7e44be6672558a76d9befbca7569 Mon Sep 17 00:00:00 2001 From: Christian Braun Date: Fri, 18 Oct 2024 09:38:09 +0200 Subject: [PATCH 2/2] Patch: added redis-authentication ability Added username/password to Settings.yaml and README.md Signed-off-by: Christian Braun --- Configuration/Settings.yaml | 2 ++ README.md | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/Configuration/Settings.yaml b/Configuration/Settings.yaml index e4e4907..6aba273 100644 --- a/Configuration/Settings.yaml +++ b/Configuration/Settings.yaml @@ -10,6 +10,8 @@ Flowpack: hostname: 127.0.0.1 port: 6379 database: 11 + username: '' + password: '' # How many content releases to keep before cleaning them up. # diff --git a/README.md b/README.md index 710648d..eb3b61d 100644 --- a/README.md +++ b/README.md @@ -209,11 +209,15 @@ To enable this feature, do the following: hostname: my-redis-hostname port: 6379 database: 11 + username: '' + password: '' staging: label: 'Staging Site' hostname: my-staging-redis-hostname port: 6379 database: 11 + username: '' + password: '' ``` 2. In `pipelines.yml`, underneath `4) TRANSFER`, comment-in and adjust the `transfer_content` task.