refactor: add set_value method to clear stale fields

The _update_feature_state_value function was setting new typed values
without clearing old value fields when changing types. This left stale
data in the database. Added set_value() method to AbstractBaseFeatureValueModel
that centralizes validation, type conversion, and ensures unused fields
are cleared.

Author: gagantrivedi

api/features/feature_states/models.py

@@ -38,3 +38,26 @@ def value(self) -> typing.Union[str, int, bool]:
             self.type,  # type: ignore[arg-type]
             self.string_value,
         )
+
+    def set_value(self, value: str, type_: str) -> None:
+        self.string_value = None
+        self.integer_value = None
+        self.boolean_value = None
+
+        match type_:
+            case "string":
+                self.string_value = value
+                self.type = STRING
+            case "integer":
+                try:
+                    self.integer_value = int(value)
+                except ValueError:
+                    raise ValueError(f"'{value}' is not a valid integer")
+                self.type = INTEGER
+            case "boolean":
+                if value.lower() not in ("true", "false"):
+                    raise ValueError(
+                        f"'{value}' is not a valid boolean (use 'true' or 'false')"
+                    )
+                self.boolean_value = value.lower() == "true"
+                self.type = BOOLEAN

api/features/versioning/versioning_service.py

@@ -4,7 +4,6 @@
 from django.db.models import Prefetch, Q, QuerySet
 from django.utils import timezone
 
-from core.constants import BOOLEAN, INTEGER, STRING
 from environments.models import Environment
 from features.models import Feature, FeatureState, FeatureStateValue
 from features.versioning.dataclasses import (
@@ -240,17 +239,7 @@ def _update_flag_for_versioning_v1(
 
 
 def _update_feature_state_value(fsv: FeatureStateValue, value: str, type_: str) -> None:
-    match type_:
-        case "string":
-            fsv.string_value = value
-            fsv.type = STRING
-        case "integer":
-            fsv.integer_value = int(value)
-            fsv.type = INTEGER
-        case "boolean":
-            fsv.boolean_value = value.lower() == "true"
-            fsv.type = BOOLEAN
-
+    fsv.set_value(value, type_)
     fsv.save()
 
 

api/tests/unit/features/test_unit_features_views.py

@@ -47,7 +47,7 @@
 from features.feature_types import MULTIVARIATE
 from features.models import Feature, FeatureSegment, FeatureState
 from features.multivariate.models import MultivariateFeatureOption
-from features.value_types import BOOLEAN, INTEGER, STRING
+from features.value_types import STRING
 from features.versioning.models import EnvironmentFeatureVersion
 from metadata.models import MetadataModelField
 from organisations.models import Organisation, OrganisationRole
@@ -3341,27 +3341,23 @@ def test_list_features_with_feature_state(
         version=100,
     )
     feature_state_value_versioned = feature_state_versioned.feature_state_value
-    feature_state_value_versioned.string_value = None
-    feature_state_value_versioned.integer_value = 2005
-    feature_state_value_versioned.type = INTEGER
+    feature_state_value_versioned.set_value("2005", "integer")
     feature_state_value_versioned.save()
 
     feature_state2 = feature2.feature_states.filter(environment=environment).first()
     feature_state2.enabled = True
     feature_state2.save()
 
     feature_state_value2 = feature_state2.feature_state_value
-    feature_state_value2.string_value = None
-    feature_state_value2.boolean_value = True
-    feature_state_value2.type = BOOLEAN
+    feature_state_value2.set_value("true", "boolean")
     feature_state_value2.save()
 
     feature_state_value3 = (
         feature3.feature_states.filter(environment=environment)
         .first()
         .feature_state_value
     )
-    feature_state_value3.string_value = "present"
+    feature_state_value3.set_value("present", "string")
     feature_state_value3.save()
 
     # This should be ignored due to identity being set.
@@ -3470,37 +3466,31 @@ def test_list_features_with_filter_by_value_search_string_and_int(
     environment_feature_version1.publish(staff_user)
 
     feature_state_value1 = feature_state1.feature_state_value
-    feature_state_value1.string_value = None
-    feature_state_value1.integer_value = 1945
-    feature_state_value1.type = INTEGER
+    feature_state_value1.set_value("1945", "integer")
     feature_state_value1.save()
 
     feature_state2 = feature2.feature_states.filter(environment=environment).first()
     feature_state2.enabled = True
     feature_state2.save()
 
     feature_state_value2 = feature_state2.feature_state_value
-    feature_state_value2.string_value = None
-    feature_state_value2.boolean_value = True
-    feature_state_value2.type = BOOLEAN
+    feature_state_value2.set_value("true", "boolean")
     feature_state_value2.save()
 
     feature_state_value3 = (
         feature3.feature_states.filter(environment=environment)
         .first()
         .feature_state_value
     )
-    feature_state_value3.string_value = "present"
-    feature_state_value3.type = STRING
+    feature_state_value3.set_value("present", "string")
     feature_state_value3.save()
 
     feature_state4 = feature4.feature_states.filter(environment=environment).first()
     feature_state4.enabled = True
     feature_state4.save()
 
     feature_state_value4 = feature_state4.feature_state_value
-    feature_state_value4.string_value = "year 1945"
-    feature_state_value4.type = STRING
+    feature_state_value4.set_value("year 1945", "string")
     feature_state_value4.save()
 
     base_url = reverse("api-v1:projects:project-features-list", args=[project.id])
@@ -3548,37 +3538,31 @@ def test_list_features_with_filter_by_search_value_boolean(
     feature_state1.save()  # type: ignore[union-attr]
 
     feature_state_value1 = feature_state1.feature_state_value  # type: ignore[union-attr]
-    feature_state_value1.string_value = None
-    feature_state_value1.integer_value = 1945
-    feature_state_value1.type = INTEGER
+    feature_state_value1.set_value("1945", "integer")
     feature_state_value1.save()
 
     feature_state2 = feature2.feature_states.filter(environment=environment).first()
     feature_state2.enabled = False
     feature_state2.save()
 
     feature_state_value2 = feature_state2.feature_state_value
-    feature_state_value2.string_value = None
-    feature_state_value2.boolean_value = True
-    feature_state_value2.type = BOOLEAN
+    feature_state_value2.set_value("true", "boolean")
     feature_state_value2.save()
 
     feature_state_value3 = (
         feature3.feature_states.filter(environment=environment)
         .first()
         .feature_state_value
     )
-    feature_state_value3.string_value = "present"
-    feature_state_value3.type = STRING
+    feature_state_value3.set_value("present", "string")
     feature_state_value3.save()
 
     feature_state4 = feature4.feature_states.filter(environment=environment).first()
     feature_state4.enabled = True
     feature_state4.save()
 
     feature_state_value4 = feature_state4.feature_state_value
-    feature_state_value4.string_value = "year 1945"
-    feature_state_value4.type = STRING
+    feature_state_value4.set_value("year 1945", "string")
     feature_state_value4.save()
 
     base_url = reverse("api-v1:projects:project-features-list", args=[project.id])
@@ -4094,7 +4078,7 @@ def test_list_features_segment_query_param_with_valid_segment(
         environment=environment,
         enabled=True,
     )
-    segment_override.feature_state_value.string_value = "segment_value"
+    segment_override.feature_state_value.set_value("segment_value", "string")
     segment_override.feature_state_value.save()
 
     base_url = reverse("api-v1:projects:project-features-list", args=[project.id])