-
Notifications
You must be signed in to change notification settings - Fork 81
Fix hessian sret type #2824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix hessian sret type #2824
Conversation
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/compiler.jl b/src/compiler.jl
index d9e3627c..c4d8d2d0 100644
--- a/src/compiler.jl
+++ b/src/compiler.jl
@@ -6630,11 +6630,11 @@ function _thunk(job, postopt::Bool = true)::Tuple{LLVM.Module, Vector{Any}, Stri
for f in functions(mod)
for i in 1:length(parameters(f))
for a in collect(parameter_attributes(f, i))
- if kind(a) == "enzyme_sret"
- API.EnzymeDumpValueRef(f)
- end
- @assert kind(a) != "enzyme_sret"
- @assert kind(a) != "enzyme_sret_v"
+ if kind(a) == "enzyme_sret"
+ API.EnzymeDumpValueRef(f)
+ end
+ @assert kind(a) != "enzyme_sret"
+ @assert kind(a) != "enzyme_sret_v"
end
end
end
@@ -6644,7 +6644,7 @@ function _thunk(job, postopt::Bool = true)::Tuple{LLVM.Module, Vector{Any}, Stri
if DumpPrePostOpt[]
API.EnzymeDumpModuleRef(mod.ref)
end
- post_optimize!(mod, JIT.get_tm(); callconv=false)
+ post_optimize!(mod, JIT.get_tm(); callconv = false)
if DumpPostOpt[]
API.EnzymeDumpModuleRef(mod.ref)
end |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2824 +/- ##
==========================================
+ Coverage 48.00% 50.87% +2.86%
==========================================
Files 13 13
Lines 1256 1256
==========================================
+ Hits 603 639 +36
+ Misses 653 617 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19872092353/artifacts/4742729204. |
requires EnzymeAD/Enzyme#2592