ENG-162486: default value set as true for enableArrowNav to meet accessibility standard for navbar #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ssherigar-c-eightfold
changed the title
ychhabra-eightfold
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Only the active tab should be focusable using the Tab key, while arrow keys should be used to navigate between non-active tabs.
Solution:
The enableArrowNav property has been added to the Tabs, which is an Octuple component, to allow arrow-key navigation between tabs
GITHUB ISSUE (Open Source Contributors)
NA
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-162486
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Navigate to TA Home -> Accounts page
Access the navbar menu via arrowKeys
Expected Result:
Keyboard users can navigate between non-active tabs using the arrow keys, while the Tab key only focuses the currently active tab, ensuring proper and accessible tab navigation.
Screen.Recording.2025-11-10.at.3.44.12.PM.mov