fix(snackbar): always tab to snackbar if active #1044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This PR improves the accessibility of the Snackbar component by simplifying the tab focus behavior. Previously, the component used a
firstTabPressedRefto track whether Tab had been pressed once, which prevented users from tabbing back to the snackbar after navigating away.Changes:
firstTabPressedRefstate trackingImpact:
Users can now consistently tab to the snackbar's close button whenever they press Tab while a snackbar is visible, making the component more predictable and accessible.
GITHUB ISSUE (Open Source Contributors)
N/A
JIRA TASK (Eightfold Employees Only):
N/A
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
yarn storybook