shortened hosts file URL creation + other tweaks #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactored and shortened URL-string creation - removed unneeded backticks (line-breaks after a pipe are always allowed) - added "0.0.0.0" as the default value for the IP parameter instead of setting it later - cleaned up regex IP replace and split up the pipeline (get-content and set-content in one pipeline isn't recommended because Get-Content may still have the file opened so Set-Content will fail to write it) - replaced all occurences of `" (escaped double-quotes) with just ' (single quotes) - replaced all instances of `Write-Host `n` with Write-Host "" as `n is technically only line-feed but Windows uses CRLF, I think it also looks nicer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(escaped double-quotes) with just
'(single quotes)with
Write-Host ""asis technically only line-feed but Windows uses CRLF, I think it also looks nicer