Fix: correct n0res calculation for complexes with ipSAE=0 (#15) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the inconsistency in n0res values reported in the OUT file versus the OUT2 file for complexes with ipSAE=0.
Problem:
For chain pairs in complexes where ipSAE=0, the OUT file reports a positive n0res value for the asymmetric chain pair B→A, while the OUT2 file correctly shows n0res = 0 for all pairs.
Solution:
Update the calculation of valid_pairs_matrix in two places by changing:
valid_pairs_matrix = (chains == chain2) & (pae_matrix < pae_cutoff)to
valid_pairs_matrix = np.outer(chains == chain1, chains == chain2) & (pae_matrix < pae_cutoff)This change ensures consistent n0res values when ipSAE=0.
Fixes: #15