Skip to content

Commit 19a61b0

Browse files
committed
added comments linking to issue
1 parent 02f35ef commit 19a61b0

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

include/nbl/builtin/hlsl/bxdf/common.hlsl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -941,6 +941,7 @@ struct beta
941941
{
942942
assert(x >= T(0.999) && y >= T(0.999));
943943

944+
// currently throws a boost preprocess error, see: https://github.com/Devsh-Graphics-Programming/Nabla/issues/932
944945
// #ifdef __HLSL_VERSION
945946
#pragma dxc diagnostic push
946947
#pragma dxc diagnostic ignored "-Wliteral-range"

include/nbl/builtin/hlsl/tgmath/impl.hlsl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,7 @@ struct l2gamma_helper<T NBL_PARTIAL_REQ_BOT(concepts::FloatingPointScalar<T>) >
539539
// implementation derived from Numerical Recipes in C, transformed for log2
540540
static T __call(T x)
541541
{
542+
// currently throws a boost preprocess error, see: https://github.com/Devsh-Graphics-Programming/Nabla/issues/932
542543
// #ifdef __HLSL_VERSION
543544
#pragma dxc diagnostic push
544545
#pragma dxc diagnostic ignored "-Wliteral-range"
@@ -588,6 +589,7 @@ struct beta_helper<T NBL_PARTIAL_REQ_BOT(concepts::FloatingPointScalar<T>) >
588589
// implementation from Numerical Recipes in C, 2nd ed.
589590
static T __call(T v1, T v2)
590591
{
592+
// currently throws a boost preprocess error, see: https://github.com/Devsh-Graphics-Programming/Nabla/issues/932
591593
// #ifdef __HLSL_VERSION
592594
#pragma dxc diagnostic push
593595
#pragma dxc diagnostic ignored "-Wliteral-range"

0 commit comments

Comments
 (0)