Skip to content

Commit c02208f

Browse files
committed
Restore the delete-database fallback
1 parent 13afd4b commit c02208f

File tree

2 files changed

+26
-12
lines changed

2 files changed

+26
-12
lines changed

src/StorageTest.tsx

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { t } from 'app/i18next-t';
22
import ErrorPanel from 'app/shell/ErrorPanel';
3-
import { get, set } from 'app/storage/idb-keyval';
3+
import { deleteDatabase, get, set } from 'app/storage/idb-keyval';
4+
import { reportException } from 'app/utils/exceptions';
45
import { errorLog } from 'app/utils/log';
56

67
export function StorageBroken() {
@@ -31,15 +32,36 @@ export async function storageTest() {
3132
try {
3233
await set('idb-test', true);
3334
} catch (e) {
34-
errorLog('storage', 'Failed IndexedDB Test', e);
35+
errorLog('storage', 'Failed IndexedDB Set Test - trying to delete database', e);
36+
try {
37+
await deleteDatabase();
38+
await set('idb-test', true);
39+
// Report to sentry, I want to know if this ever works
40+
reportException('deleting database fixed IDB set', e);
41+
} catch (e2) {
42+
errorLog('storage', 'Failed IndexedDB Set Test - deleting database did not help', e);
43+
}
44+
reportException('Failed IndexedDB Set Test', e);
3545
return false;
3646
}
3747

3848
try {
3949
const idbValue = await get<boolean>('idb-test');
4050
return idbValue;
4151
} catch (e) {
42-
errorLog('storage', 'Failed IndexedDB Test', e);
52+
errorLog('storage', 'Failed IndexedDB Get Test - trying to delete database', e);
53+
try {
54+
await deleteDatabase();
55+
const idbValue = await get<boolean>('idb-test');
56+
if (idbValue) {
57+
// Report to sentry, I want to know if this ever works
58+
reportException('deleting database fixed IDB get', e);
59+
}
60+
return idbValue;
61+
} catch (e2) {
62+
errorLog('storage', 'Failed IndexedDB Get Test - deleting database did not help', e);
63+
}
64+
reportException('Failed IndexedDB Get Test', e);
4365
return false;
4466
}
4567
}

src/app/utils/exceptions.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,7 @@ if ($featureFlags.sentry) {
4747
dsn: 'https://[email protected]/279673',
4848
release: $DIM_VERSION,
4949
environment: $DIM_FLAVOR,
50-
ignoreErrors: [
51-
/QuotaExceededError/,
52-
'HTTP 503 returned',
53-
'Waiting due to HTTP 503',
54-
/FatalTokenError/,
55-
/Failed to fetch/,
56-
/AbortError/,
57-
/Non-Error promise rejection/,
58-
],
50+
ignoreErrors: [],
5951
sampleRate: $DIM_VERSION === 'beta' ? 0.5 : 0.01, // Sample Beta at 50%, Prod at 1%
6052
attachStacktrace: true,
6153
integrations: [

0 commit comments

Comments
 (0)