fixed most of the failing tests - breaking api

Author: yonjah

README.md

@@ -374,10 +374,9 @@ import Base from 'ember-validations/validators/base';
 import Ember from 'ember';
 
 export default Base.extend({
-  init: function() {
+  pushDependentValidationKeys: function() {
     // this call is necessary, don't forget it!
     this._super();
-
     this.dependentValidationKeys.pushObject(this.options.alsoWatch);
   },
   call: function() {
@@ -388,8 +387,8 @@ export default Base.extend({
 });
 ```
 
-The `init` function is given access to the `this.options` which is simply
-a POJO of the options passed to the validator.
+The `pushDependentValidationKeys` function is called during `init` and is given access 
+to the `this.options` which is simply a POJO of the options passed to the validator.
 `dependentValidationKeys` is the collection of paths relative to
 `this.model` that will be observed for changes. If any changes occur on
 any given path the validator will automatically trigger.

addon/validators/base.js

@@ -12,15 +12,16 @@ export default Ember.Object.extend({
       unless: get(this, 'options.unless')
     };
     this.dependentValidationKeys.pushObject(this.property);
-    this.pushConditionalDependentValidationKeys();
+    // this.model.addObserver(this.property, this, this._validate);
+    this.pushDependentValidationKeys();
     this.addObserversForDependentValidationKeys();
   },
   addObserversForDependentValidationKeys: function() {
     this.dependentValidationKeys.forEach(function(key) {
       this.model.addObserver(key, this, this._validate);
     }, this);
   },
-  pushConditionalDependentValidationKeys: function() {
+  pushDependentValidationKeys: function() {
     Ember.A(['if', 'unless']).forEach((conditionalKind) => {
       const conditional = this.conditionals[conditionalKind];
       if (typeof(conditional) === 'string' && typeof(this.model[conditional]) !== 'function') {

addon/validators/local/confirmation.js

@@ -10,13 +10,16 @@ export default Base.extend({
     this.originalProperty = this.property;
     this.property = this.property + 'Confirmation';
     this._super();
-    this.dependentValidationKeys.pushObject(this.originalProperty);
     /*jshint expr:true*/
     if (this.options === true) {
       set(this, 'options', { attribute: this.originalProperty });
       set(this, 'options', { message: Messages.render('confirmation', this.options) });
     }
   },
+  pushDependentValidationKeys: function () {
+    this._super();
+    this.dependentValidationKeys.pushObject(this.originalProperty);
+  },
   call: function() {
     var original = get(this.model, this.originalProperty);
     var confirmation = get(this.model, this.property);