Skip to content

Commit 43e57e8

Browse files
committed
💚(projet) fix ci error handling
CI execution used to stop right after a git lint error so we made these changes to allow full CI execution
1 parent 063fadf commit 43e57e8

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

‎.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,15 @@ jobs:
4747
run: ~/.local/bin/gitlint --commits origin/main..HEAD
4848

4949
- name: Setup PHP ${{ matrix.php }}
50+
if: ${{ !cancelled() }}
5051
uses: shivammathur/setup-php@v2
5152
with:
5253
php-version: ${{ matrix.php }}
5354
ini-values: max_input_vars=5000
5455
coverage: xdebug
5556

5657
- name: Initialise moodle-plugin-ci
58+
if: ${{ !cancelled() }}
5759
run: |
5860
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^4
5961
echo $(cd ci/bin; pwd) >> $GITHUB_PATH
@@ -62,6 +64,7 @@ jobs:
6264
echo "NVM_DIR=$HOME/.nvm" >> $GITHUB_ENV
6365
6466
- name: Install moodle-plugin-ci
67+
if: ${{ !cancelled() }}
6568
run: moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1
6669
env:
6770
DB: ${{ matrix.database }}

‎block_iagora.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public function get_content() {
6161
}
6262

6363
/**
64-
* Defines in which pages this block can be added.
64+
* Define in which pages this block can be added.
6565
*
6666
* @return array of the pages where the block can be added.
6767
*/

‎edit_form.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ protected function specific_definition($mform) {
4343
$mform->setType('config_iframeurl', PARAM_URL);
4444
$mform->addHelpButton('config_iframeurl', 'iframeurl', 'block_iagora');
4545
$mform->setDefault('config_iframeurl', '');
46-
$mform->addElement('static', 'iframe_url_desc', '', get_string('iframe_url_desc', 'block_iagora'));
46+
$mform->addElement('static', 'iframeurl_desc', '', get_string('iframeurl_desc', 'block_iagora'));
4747

4848
}
4949

‎lang/en/block_iagora.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
2323
*/
2424

25-
$string['iframe_url_desc'] = 'Public URL available for chat iframe';
2625
$string['iframeurl'] = 'Iframe URL';
26+
$string['iframeurl_desc'] = 'Public URL available for chat iframe';
2727
$string['iframeurl_help'] = 'Public URL for the Microsoft Copilot chat iframe';
2828
$string['noiframeurl'] = 'No url defined for this block. Please configure a URL in the block parameters';
2929
$string['pluginname'] = 'IAGORA';

0 commit comments

Comments
 (0)