Skip to content

Commit 71487b8

Browse files
committed
[Debugger] Fix log snapshot tests
Ensure that the probe sent to the tracer contains a `capture` object, when `captureSnapshot` is set to `true`. This makes the test probe look more like a real probe, since a tracer might expect this object to be present (the Node.js tracer expects this).
1 parent c81c019 commit 71487b8

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

tests/debugger/test_debugger_probe_snapshot.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ class Test_Debugger_Line_Probe_Snaphots(BaseDebuggerProbeSnaphotTest):
213213
def setup_log_line_snapshot(self):
214214
self._setup("probe_snapshot_log_line", "/debugger/log", "log", lines=None)
215215

216-
@bug(context.library == "nodejs", reason="DEBUG-4611")
217216
def test_log_line_snapshot(self):
218217
self._assert()
219218
self._validate_snapshots()
@@ -298,7 +297,6 @@ class Test_Debugger_Line_Probe_Snaphots_With_SCM(BaseDebuggerProbeSnaphotTest):
298297
def setup_log_line_snapshot(self):
299298
self._setup("probe_snapshot_log_line", "/debugger/log", "log", lines=None)
300299

301-
@bug(context.library == "nodejs", reason="DEBUG-4611")
302300
def test_log_line_snapshot(self):
303301
self._assert()
304302
self._validate_snapshots()

tests/debugger/utils/probes/probe_snapshot_log_line.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
"id": "",
66
"version": 0,
77
"captureSnapshot": true,
8+
"capture": {
9+
"maxFieldCount": 200
10+
},
811
"where": {
912
"typeName": null,
1013
"sourceFile": "ACTUAL_SOURCE_FILE",

tests/debugger/utils/probes/probe_snapshot_log_mixed.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
"id": "",
66
"version": 0,
77
"captureSnapshot": true,
8+
"capture": {
9+
"maxFieldCount": 200
10+
},
811
"where": {
912
"typeName": "ACTUAL_TYPE_NAME",
1013
"methodName": "MixProbe",
@@ -17,6 +20,9 @@
1720
"id": "",
1821
"version": 0,
1922
"captureSnapshot": true,
23+
"capture": {
24+
"maxFieldCount": 200
25+
},
2026
"where": {
2127
"typeName": null,
2228
"sourceFile": "ACTUAL_SOURCE_FILE",

0 commit comments

Comments
 (0)