From 79a9271692763d5a453ae230078f8e89ae5b4610 Mon Sep 17 00:00:00 2001 From: jean-philippe bempel Date: Fri, 24 Oct 2025 10:29:05 +0200 Subject: [PATCH] Fix logging when uninstrumenting cannot happen if we have a thread in a loop that cannot exit the instrumented method for a while, instrumentation cannot be done. But probe is removed from metadata and cannot be resolved. We were logging this status which is in fact not helpful and generate noise. If probe cannot be resolved we just ignore the instrumentation --- .../com/datadog/debugger/agent/ConfigurationUpdater.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/ConfigurationUpdater.java b/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/ConfigurationUpdater.java index 6fddf056848..755c15ea667 100644 --- a/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/ConfigurationUpdater.java +++ b/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/ConfigurationUpdater.java @@ -4,7 +4,6 @@ import static com.datadog.debugger.agent.DebuggerProductChangesListener.METRIC_PROBE_PREFIX; import static com.datadog.debugger.agent.DebuggerProductChangesListener.SPAN_DECORATION_PROBE_PREFIX; import static com.datadog.debugger.agent.DebuggerProductChangesListener.SPAN_PROBE_PREFIX; -import static datadog.trace.api.telemetry.LogCollector.SEND_TELEMETRY; import com.datadog.debugger.instrumentation.InstrumentationResult; import com.datadog.debugger.probe.ExceptionProbe; @@ -252,11 +251,7 @@ private void storeDebuggerDefinitions(ConfigurationComparer changes) { // /!\ This is called potentially by multiple threads from the instrumented code /!\ @Override public ProbeImplementation resolve(int probeIndex) { - ProbeImplementation probeImplementation = probeMetadata.getProbe(probeIndex); - if (probeImplementation == null) { - ratelimitedLogger.warn(SEND_TELEMETRY, "Cannot resolve probe index={}", probeIndex); - } - return probeImplementation; + return probeMetadata.getProbe(probeIndex); } private static void applyRateLimiter(