decoupled the native side from DI/ER env vars to support HandsOff Config

Author: GreenMatan

tracer/src/Datadog.Tracer.Native/debugger_environment_variables.h

@@ -16,13 +16,6 @@ namespace environment
     const WSTRING internal_instrument_all_lines_enabled = WStr("DD_INTERNAL_DEBUGGER_INSTRUMENT_ALL_LINES");
     const WSTRING internal_instrument_all_lines_path = WStr("DD_INTERNAL_DEBUGGER_INSTRUMENT_ALL_LINES_PATH");
 
-    // Determines if the Dynamic Instrumentation (aka live debugger) is enabled.
-    const WSTRING dynamic_instrumentation_enabled = WStr("DD_DYNAMIC_INSTRUMENTATION_ENABLED");
-
-    // Determines if the Exception Replay product is enabled.
-    const WSTRING exception_debugging_enabled = WStr("DD_EXCEPTION_DEBUGGING_ENABLED"); // Old name
-    const WSTRING exception_replay_enabled = WStr("DD_EXCEPTION_REPLAY_ENABLED");
-
 } // namespace environment
 } // namespace debugger
 

tracer/src/Datadog.Tracer.Native/debugger_environment_variables_util.cpp

@@ -4,24 +4,6 @@
 namespace debugger
 {
 
-bool IsDynamicInstrumentationEnabled()
-{
-    CheckIfTrue(GetEnvironmentValue(environment::dynamic_instrumentation_enabled));
-}
-
-bool IsExceptionReplayEnabled()
-{
-    static int sValue = -1;
-    if (sValue == -1)
-    {
-        const auto old_exception_replay_flag = GetEnvironmentValue(environment::exception_debugging_enabled);
-        const auto new_exception_replay_flag = GetEnvironmentValue(environment::exception_replay_enabled);
-        sValue = (IsTrue(old_exception_replay_flag) || IsTrue(new_exception_replay_flag)) ? 1 : 0;
-    }
-
-    return sValue == 1;
-}
-
 bool IsDebuggerInstrumentAllEnabled()
 {
     CheckIfTrue(GetEnvironmentValue(environment::internal_instrument_all_enabled));

tracer/src/Datadog.Tracer.Native/debugger_probes_instrumentation_requester.cpp

@@ -330,19 +330,6 @@ DebuggerProbesInstrumentationRequester::DebuggerProbesInstrumentationRequester(
     m_work_offloader(work_offloader),
     m_fault_tolerant_method_duplicator(fault_tolerant_method_duplicator)
 {
-    auto diEnabled = IsDynamicInstrumentationEnabled();
-    if (diEnabled == false)
-    {
-        Logger::Debug("Dynamic Instrumentation is disabled");
-    }
-
-    auto erEnabled = IsExceptionReplayEnabled();
-    if (erEnabled == false)
-    {
-        Logger::Debug("Exception Replay is explicitly disabled");
-    }
-
-    is_debugger_or_exception_debugging_enabled = diEnabled || erEnabled;
 }
 
 void DebuggerProbesInstrumentationRequester::RemoveProbes(debugger::DebuggerRemoveProbesDefinition* removeProbes,
@@ -1027,13 +1014,8 @@ void DebuggerProbesInstrumentationRequester::ModuleLoadFinished_AddMetadataToMod
 
 HRESULT STDMETHODCALLTYPE DebuggerProbesInstrumentationRequester::ModuleLoadFinished(const ModuleID moduleId)
 {
-    if (!is_debugger_or_exception_debugging_enabled)
-    {
-        return S_OK;
-    }
-
     // IMPORTANT: The call to `ModuleLoadFinished_AddMetadataToModule` must be in `ModuleLoadFinished` as mutating the
-    // layout of types is only feasible prior the type is loaded.s
+    // layout of types is only feasible prior the type is loaded.
     ModuleLoadFinished_AddMetadataToModule(moduleId);
     RequestRejitForLoadedModule(moduleId);
     return S_OK;

tracer/src/Datadog.Tracer.Native/debugger_probes_instrumentation_requester.h

@@ -40,7 +40,6 @@ class DebuggerProbesInstrumentationRequester
     std::shared_ptr<RejitHandler> m_rejit_handler = nullptr;
     std::shared_ptr<RejitWorkOffloader> m_work_offloader = nullptr;
     std::shared_ptr<fault_tolerant::FaultTolerantMethodDuplicator> m_fault_tolerant_method_duplicator = nullptr;
-    bool is_debugger_or_exception_debugging_enabled = false;
     std::unordered_map<std::pair<std::string, mdToken>, std::vector<int>, pair_hash> explorationLineProbes;
     std::once_flag explorationLinesInitFlag;