Skip to content

Conversation

@michael-richey
Copy link
Collaborator

What does this PR do?

Made changes needed to onboard the datadog demo organization.

Description of the Change

General Changes

  • At some point in the past connect_id was an abstract class, but it hasn't been for awhile. Removed connect_id functions that were just pass so they would use the super class's version of connect_id to maintain dependencies
  • Moved the "skipping" log messages from Info to Debug, there are thousands of them when you're syncing a large org
  • Cleanup/deletes used to happen in parallel. This was specifically a problem with deleting teams and team-membership as the API for teams cascades deletes to team-memberships. So if you deleted team A the API would delete team-memberships A1, A2, and A3, there problem was we had parallel requests to delete those memberships and they would start failing. Deletes occur according to the dependency graph now, so for example we await for all team memberships to be deleted before deleting any teams.

Resource Specific Changes

  • Dashboards: Skip rather than Fail if we don't have access
  • Metrics Metadata: The distribution metrics type isn't supported, Skip rather than Fail
  • Monitors: Connect to rum_applications
  • Notebooks: Skip rather than Fail if we don't have access
  • Rum Applications: add another field to ignore, the preview depends on feature flags
  • Sensitive Data Scanner Groups: Narrow ignoring fields from relationships to just relationships.rules so we can pull in the configuration data id, this is due to an API change
  • SLOs: SLOs created in R1 can be created with Monitors A, B, and C. If Monitor B is deleted in R1, the SLO continues with just A and C, but is still defined with A, B, and C. sync-cli will copy all existing monitors from R1 to R2, but only A and C exist so only A and C are copied. When we try to create a new SLO in R2 that references A, B, and C the create will fail because B doesn't exist in R2. The code change removes the reference to monitor B so that the SLO can be created in R2
  • Synthetics Mobile Applications: Remove circular dependency to versions
  • Team Memberships: Brought more inline with the rest of sync-cli resources, does less checking of the R2 org and relies more on the state files. Greatly simplifies it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants