Skip to content

Conversation

@nitin-koshti11
Copy link

What does this PR do?

  • Alters existing functionality
    Remove invalid caBundle from manifest.

As of Kubernetes 1.31, Updates to CustomResourceDefinition are no longer allowed to transition a valid caBundle field to an invalid caBundle field

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

{{- else }}
caBundle: {{ b64enc $ca.Cert }}
{{- end }}
# must NOT specify caBundle here, as of k8s 1.31:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! We can remove the caBundle entry entirely, we don't need these comments.

name: chaos-controller
webhooks:
- clientConfig:
{{- if not .Values.controller.webhook.generateCert }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this value from values.yaml if it's no longer used anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants