clean

Author: amortemousque

benchmark/configuration.ts

@@ -0,0 +1,5 @@
+export const TEST_APP_URL = 'https://df1fyr56hap9d.cloudfront.net/'
+export const SDK_BUNDLE_URL = 'https://df1fyr56hap9d.cloudfront.net/datadog-rum.js'
+export const APPLICATION_ID = '9fa62a5b-8a7e-429d-8466-8b111a4d4693'
+export const CLIENT_TOKEN = 'pubab31fd1ab9d01d2b385a8aa3dd403b1d'
+export const DATADOG_SITE = 'datadoghq.com'

benchmark/createBenchmarkTest.ts

@@ -6,23 +6,20 @@ import { startProfiling } from './profilers'
 import { reportToConsole } from './reporters/reportToConsole'
 import { reportToDatadog } from './reporters/reportToDatadog'
 import { isContinuousIntegration } from './environment'
+import { CLIENT_TOKEN, APPLICATION_ID, DATADOG_SITE, TEST_APP_URL, SDK_BUNDLE_URL } from './configuration'
 
-const testAppUrl = 'https://df1fyr56hap9d.cloudfront.net/'
-const sdkBundleUrl = 'https://df1fyr56hap9d.cloudfront.net/datadog-rum.js'
-const applicationId = '9fa62a5b-8a7e-429d-8466-8b111a4d4693'
-const clientToken = 'pubab31fd1ab9d01d2b385a8aa3dd403b1d'
-const datadogSite = 'datadoghq.com'
-const scenarioConfigurations = ['none', 'rum', 'rum_replay', 'rum_profiling', 'none_with_headers'] as const
 
-type ScenarioConfiguration = (typeof scenarioConfigurations)[number]
+const SCENARIO_CONFIGURATIONS = ['none', 'rum', 'rum_replay', 'rum_profiling', 'none_with_headers'] as const
+
+type ScenarioConfiguration = (typeof SCENARIO_CONFIGURATIONS)[number]
 type TestRunner = (page: Page, takeMeasurementsAndGoto: (pageUrl: string) => Promise<void>, appUrl: string) => Promise<void> | void
 
 
 export function createBenchmarkTest(scenarioName: string) {
   return {
     run(runner: TestRunner) {
       const metrics: Record<string, Metrics> = {}
-      scenarioConfigurations.forEach((scenarioConfiguration) => {
+      SCENARIO_CONFIGURATIONS.forEach((scenarioConfiguration) => {
         test(`${scenarioName} benchmark ${scenarioConfiguration}`, async ({ page }) => {
           await page.setExtraHTTPHeaders({ 'Accept-Language': 'en-US' })
 
@@ -42,7 +39,7 @@ export function createBenchmarkTest(scenarioName: string) {
       test.afterAll(async () => {
         reportToConsole(metrics)
         if (isContinuousIntegration) {
-          await reportToDatadog(metrics, applicationId, scenarioName)
+          await reportToDatadog(metrics, scenarioName)
         }
       })
     },
@@ -59,9 +56,9 @@ interface PageInitScriptParameters {
 
 async function injectSDK(page: Page, scenarioConfiguration: ScenarioConfiguration, scenarioName: string) {
   const configuration: Partial<RumInitConfiguration> = {
-    clientToken,
-    applicationId,
-    site: datadogSite,
+    clientToken: CLIENT_TOKEN,
+    applicationId: APPLICATION_ID,
+    site: DATADOG_SITE,
     profilingSampleRate: scenarioConfiguration === 'rum_profiling' ? 100 : 0,
     sessionReplaySampleRate: scenarioConfiguration === 'rum_replay' ? 100 : 0,
   }
@@ -98,7 +95,7 @@ async function injectSDK(page: Page, scenarioConfiguration: ScenarioConfiguratio
         }
       })
     },
-    { configuration, sdkBundleUrl, scenarioConfiguration, scenarioName }
+    { configuration, sdkBundleUrl: SDK_BUNDLE_URL, scenarioConfiguration, scenarioName }
   )
 }
 
@@ -108,7 +105,7 @@ function shouldInjectSDK(scenarioConfiguration: ScenarioConfiguration): boolean
 
 
 function buildAppUrl(scenarioConfiguration: ScenarioConfiguration): string {
-  const url = new URL(testAppUrl)
+  const url = new URL(TEST_APP_URL)
   if (scenarioConfiguration === 'rum_profiling' || scenarioConfiguration === 'none_with_headers') {
     url.searchParams.set('profiling', 'true')
   }

benchmark/reporters/reportToDatadog.ts

@@ -1,3 +1,4 @@
+import { DATADOG_SITE } from '../configuration'
 import type { Metrics } from '../profiling.type'
 import { fetchHandlingError } from '../../scripts/lib/executionUtils'
 import { getOrg2ApiKey } from '../../scripts/lib/secrets'
@@ -9,32 +10,29 @@ interface DatadogSeries {
 }
 
 const METRIC_PREFIX = 'browser_sdk.benchmark'
-const DATADOG_SITE = 'datad0g.com'
 
 export async function reportToDatadog(
   metricsTable: Record<string, Metrics>,
-  applicationId: string,
   scenarioName: string
 ) {
-  const series = convertMetricsToSeries(metricsTable, applicationId, scenarioName)
+  const series = convertMetricsToSeries(metricsTable, scenarioName)
   const result = await sendToDatadog(series)
 
   console.log(`✅ Successfully sent ${series.length} metrics to Datadog`)
   console.log(`📊 View metrics in Datadog: https://app.${DATADOG_SITE}/metric/explorer?query=${METRIC_PREFIX}.*`)
-  console.log(`🏷️  Filter by tags: application_id:${applicationId}, scenario:${scenarioName}`)
+  console.log(`🏷️  Filter by tags: scenario:${scenarioName}`)
   return result
 }
 
 function convertMetricsToSeries(
   metricsTable: Record<string, Metrics>,
-  applicationId: string,
   scenarioName: string
 ): DatadogSeries[] {
   const timestamp = Math.floor(Date.now() / 1000)
   const series: DatadogSeries[] = []
 
   for (const [configuration, metrics] of Object.entries(metricsTable)) {
-    const tags = [`application_id:${applicationId}`, `scenario:${scenarioName}`, `configuration:${configuration}`]
+    const tags = [`scenario:${scenarioName}`, `configuration:${configuration}`]
 
     for (const [key, value] of Object.entries(metrics)) {
       series.push({