Skip to content

Coverity 488780 - uninitialized variable #3170

@steven-bellock

Description

@steven-bellock

Coverity is confused by

if ((spdm_request->request_attributes &
SPDM_GET_ENDPOINT_INFO_REQUEST_ATTRIBUTE_SIGNATURE_REQUESTED) != 0) {
if (context->connection_info.algorithm.req_base_asym_alg != 0) {
signature_size = libspdm_get_req_asym_signature_size(
context->connection_info.algorithm.req_base_asym_alg);
}
if (context->connection_info.algorithm.req_pqc_asym_alg != 0) {
signature_size = libspdm_get_req_pqc_asym_signature_size(
context->connection_info.algorithm.req_pqc_asym_alg);
}
if ((spdm_request->request_attributes &
SPDM_GET_ENDPOINT_INFO_REQUEST_ATTRIBUTE_SIGNATURE_REQUESTED) != 0) {
LIBSPDM_ASSERT(*response_size >= (sizeof(spdm_endpoint_info_response_t) +
SPDM_NONCE_SIZE + sizeof(uint32_t) +
signature_size));
spdm_response_size = sizeof(spdm_endpoint_info_response_t) + SPDM_NONCE_SIZE +
sizeof(uint32_t) + signature_size;
and thinks that signature_size is uninitialized. Maybe change

if (context->connection_info.algorithm.req_pqc_asym_alg != 0)

to just else?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions