Skip to content

Conversation

@woodseowl
Copy link
Collaborator

@woodseowl woodseowl commented Oct 20, 2025

Factors CUAuth out as a separate package through cornell-custom-dev/laravel-cu-auth.

  • composer requires cornell-custom-dev/laravel-cu-auth (which provides PHP SAML library)
  • removes the CUAuth directory and installer test
  • expands the "starterkit:install" command (with test coverage) to install cu-auth configs

# Conflicts:
#	composer.json
#	tests/Feature/CUAuth/ApacheShibTest.php
#	tests/Feature/InstallStarterKitTest.php
@woodseowl woodseowl changed the title Cuauth dependency CU Auth external dependency Oct 20, 2025
@woodseowl woodseowl mentioned this pull request Oct 20, 2025
@woodseowl woodseowl requested a review from Copilot October 20, 2025 18:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extracts the CUAuth functionality into a separate external package (cornell-custom-dev/laravel-cu-auth), removing the embedded implementation and updating the starter kit to depend on and configure the external package instead.

  • Removes all CUAuth source code and tests from the starter kit package
  • Adds dependency on cornell-custom-dev/laravel-cu-auth package
  • Expands the install command to support configuring the external CUAuth package with SAML certificates

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
composer.json Adds dependency on cornell-custom-dev/laravel-cu-auth package and removes internal CUAuth service provider
src/StarterKitServiceProvider.php Adds install options for PHP SAML toolkit configuration and certificate generation
tests/Feature/InstallStarterKitTest.php Updates tests to cover new install options and removes obsolete CUAuth installer test
src/CUAuth/* Removes all CUAuth source files (middleware, controllers, events, listeners, data objects, service provider, routes, config, documentation)
README.md Updates CUAuth description and PHP version reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants