Fixes #30
Open
Fixes #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of `extend U with x do R` the value `x` will not be a member of `U` (as the UpdateSet wasn't consistent `x` wasn't added to `U`). Therefore any writes to a function with a signature `.. * U * .. -> ..` or `.. -> U` will report `x` not being a member of `U`, although there is nothing wrong with such an update.
.. add @OverRide, remove unnecessary casts, and re-order methods in HashState to match the State interface and HashStorage
…getFunctionName The name is already known iff the FunctionElement is loaded from the storage
- and useIncrementalCompilation=false
Tests all cases of SetPlugin.compose, especially aggregateLocationForComposition and eradicateConflictingIncrementalUpdates
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for taking the time to look into my PRs and the merge!
In the meantime I developed some more changes and collected some of them here. This PR contains a bugfix in the aggregation of SetElements, some code cleanup and also some minor logging and performance improvements.
Just a heads up: I'm also working on more performance changes, mostly regarding synchronized code and also a upgrade from EDU.oswego.cs.dl.util.concurrent to java.util.concurrent.ForkJoinPool, but haven't finished that for a PR yet.