Skip to content

Commit 73fd7a6

Browse files
authored
Merge pull request #3475 from rjwills28/ISSUE-3458_fix_opening_duplicate_displays
Issue-3458: fix opening duplicate displays due to arbitrary macros added to URI
2 parents 112a05f + e94a71c commit 73fd7a6

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

app/display/model/src/main/java/org/csstudio/display/builder/model/widgets/EmbeddedDisplayWidget.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -307,17 +307,6 @@ public WidgetProperty<?> getProperty(String name) throws IllegalArgumentExceptio
307307
return super.getProperty(name);
308308
}
309309

310-
@Override
311-
public Macros getEffectiveMacros()
312-
{
313-
final Macros macros = new Macros(super.getEffectiveMacros());
314-
315-
// Legacy "Linking Container" defined a "Linking Container ID" macro.
316-
macros.add("LCID", getID());
317-
318-
return macros;
319-
}
320-
321310
/** @return 'file' property */
322311
public WidgetProperty<String> propFile()
323312
{

app/display/model/src/main/resources/display_model_preferences.properties

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,9 @@ font_files=examples:font.def
3131
# * Must start with character
3232
# * May then contain characters or numbers
3333
# * May also contain underscores
34-
#
35-
macros=<EXAMPLE_MACRO>Value from Preferences</EXAMPLE_MACRO><TEST>true</TEST>
34+
# E.g.
35+
# macros=<EXAMPLE_MACRO>Value from Preferences</EXAMPLE_MACRO><TEST>true</TEST>
36+
macros=
3637

3738

3839
# Timeout [ms] for loading files: Displays, but also color, font, widget class files

0 commit comments

Comments
 (0)