fix(buildParams) array values without [] suffixed keys are not transformed to LHS format (#39)

* fix missing slash in delete function

* refactoring searchParams builder

* fix: temp key

* add test coverage for object array parameter

* simplify `buildSearchParams`

---------

Co-authored-by: EdsolXY <[email protected]>
Co-authored-by: daedalus <[email protected]>

Author: Edsol

src/utils/buildSearchParams.js

@@ -7,16 +7,25 @@
 const buildSearchParams = (query) => {
 	const params = new URLSearchParams();
 
-	for (const key in query) {
-		if (key.endsWith('[]')) {
-			query[key].forEach((entry) => {
-				params.append(key, entry);
-			});
-		} else {
-			params.set(key, query[key]);
+	for (let key in query) {
+		if (Object.hasOwnProperty.call(query, key)) {
+			const value = query[key];
+
+			// LHS requires array variables to be added ones per item in array
+			if (Array.isArray(value)) {
+				// LHS bracket notiation requires array keys to end with []
+				if (!key.endsWith('[]')) {
+					key += '[]';
+				}
+
+				for (const entry of value) {
+					params.append(key, entry);
+				}
+			} else {
+				params.set(key, value);
+			}
 		}
 	}
-
 	return params;
 };
 

test/utils.spec.js

@@ -13,13 +13,16 @@ describe('Testing buildSearchParams util', () => {
 			archive: false,
 			order_by: 'due_date',
 			'statuses[]': ['in progress', 'completed'],
+			assignees: [1, 2],
 		};
 
 		const expectedOutput = new URLSearchParams([
 			['archived', 'false'],
 			['order_by', 'due_date'],
 			['statuses[]', 'in progress'],
 			['statuses[]', 'completed'],
+			['assignees[]', 1],
+			['assignees[]', 2],
 		]);
 
 		assert.deepEqual(buildSearchParams(params), expectedOutput);