saveMachineStateToURL only available to arm64 machine ?

[t0k4rt]

Dear @Code-Hex Thanks for your work on this library.
I'm new to this codebase and was digging why lima was not providing snapshots using VZ framework given that it should be possible using apple vz docs here.
It leads me to this repository and was looking for the implementation of savemachinestateto which is implement in virtualization_arm64.go.

File naming _arm64 and // +build darwin,arm64 suggest that it is a specific arm64 code path I'm I right ?

But the savemachinestateto function does not seems to be limited to that platform only and should be available on both apple and intel silicon.

Do you know any limitation that prevent savemachinestateto to be implemented for intel silicon hardware ?
I would be interested in implementing such feature for intel silicon.
Thanks a lot !

[cfergeau]

This could be an oversight, you can try moving this code to virtualization_14.go instead of virtualization_arm64.go and see if it builds. If it does, then you can test if it works as expected in lima.

[t0k4rt]

Yes I could have tried that first ^^

When compiling the code it triggers a warning that leads me to apple vz framework header with this:

#if defined(__arm64__)

- (void)restoreMachineStateFromURL:(NSURL *)saveFileURL completionHandler:(void (^)(NSError * _Nullable errorOrNil))completionHandler NS_SWIFT_NAME(restoreMachineStateFrom(url:completionHandler:)) API_AVAILABLE(macos(14.0));

- (void)saveMachineStateToURL:(NSURL *)saveFileURL completionHandler:(void (^)(NSError * _Nullable errorOrNil))completionHandler NS_SWIFT_NAME(saveMachineStateTo(url:completionHandler:)) API_AVAILABLE(macos(14.0));
#endif

So indeed these two methods are limited to arm64 ... that information could have been made more accessible in the docs ...

Headers are accessible here just in case: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Virtualization.framework/Headers/VZVirtualMachineConfiguration.h