Skip to content

Commit f3b1b31

Browse files
Merge branch 'main' into cx-shaked-karta-fix-local-resolution
2 parents 5f97b59 + 4c7a90d commit f3b1b31

File tree

3 files changed

+21
-16
lines changed

3 files changed

+21
-16
lines changed

go.mod

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ module github.com/Checkmarx/containers-resolver
33
go 1.24.1
44

55
require (
6-
github.com/Checkmarx/containers-images-extractor v1.0.10
7-
github.com/Checkmarx/containers-syft-packages-extractor v1.0.14
8-
github.com/Checkmarx/containers-types v1.0.4
6+
github.com/Checkmarx/containers-images-extractor v1.0.16
7+
github.com/Checkmarx/containers-syft-packages-extractor v1.0.15
8+
github.com/Checkmarx/containers-types v1.0.9
99
github.com/rs/zerolog v1.34.0
1010
github.com/stretchr/testify v1.10.0
1111
)

go.sum

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ github.com/BurntSushi/toml v0.4.1/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbi
6161
github.com/BurntSushi/toml v1.5.0 h1:W5quZX/G/csjUnuI8SUYlsHs9M38FC7znL0lIO+DvMg=
6262
github.com/BurntSushi/toml v1.5.0/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2lLoLwho=
6363
github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
64-
github.com/Checkmarx/containers-images-extractor v1.0.10 h1:RxXbw03SPkVjvw2XR05RSLh+YTTQ2KshrQhOhTMFey8=
65-
github.com/Checkmarx/containers-images-extractor v1.0.10/go.mod h1:KqOq3DUekL9VbklOVgTdZJC/+KLOYdfEoCSY/SWHdxU=
66-
github.com/Checkmarx/containers-syft-packages-extractor v1.0.14 h1:wh+VBe3wZrN4qwxw3OV3tO6UVa6Tc7X6ib+RlWKNe7s=
67-
github.com/Checkmarx/containers-syft-packages-extractor v1.0.14/go.mod h1:EFeB4//lO4KMVj9+eMg6z5jnO9F1e1T4jUoIcx0/19M=
68-
github.com/Checkmarx/containers-types v1.0.4 h1:Sa3y7IraZeeppspV0AmqYTNoDEHqn9yZZZq895SkabM=
69-
github.com/Checkmarx/containers-types v1.0.4/go.mod h1:KR0w8XCosq3+6jRCfQrH7i//Nj2u11qaUJM62CREFZA=
64+
github.com/Checkmarx/containers-images-extractor v1.0.16 h1:Uo69VEcPe1Puy47JeRn902xN+e+nFmmFAcHlbdQeqy8=
65+
github.com/Checkmarx/containers-images-extractor v1.0.16/go.mod h1:hRXOiq6Vw2QiIuxIqV+6+osMk0vvIpoMdTMLyz9OfE8=
66+
github.com/Checkmarx/containers-syft-packages-extractor v1.0.15 h1:yM7Plt86oL47Kijr1fwsrWwuACNTwWgxZSZ/lifXTlk=
67+
github.com/Checkmarx/containers-syft-packages-extractor v1.0.15/go.mod h1:Jr3dQVFslMCJ+8orsF1orFn05cO3mprUy5b43yn0IIM=
68+
github.com/Checkmarx/containers-types v1.0.9 h1:LbHDj9LZ0x3f28wDx398WC19sw0U0EfEewHMLStBwvs=
69+
github.com/Checkmarx/containers-types v1.0.9/go.mod h1:KR0w8XCosq3+6jRCfQrH7i//Nj2u11qaUJM62CREFZA=
7070
github.com/CycloneDX/cyclonedx-go v0.9.2 h1:688QHn2X/5nRezKe2ueIVCt+NRqf7fl3AVQk+vaFcIo=
7171
github.com/CycloneDX/cyclonedx-go v0.9.2/go.mod h1:vcK6pKgO1WanCdd61qx4bFnSsDJQ6SbM2ZuMIgq86Jg=
7272
github.com/DATA-DOG/go-sqlmock v1.5.2 h1:OcvFkGmslmlZibjAjaHm3L//6LiuBgolP7OputlJIzU=

pkg/containerResolver/containerScanner_test.go

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ type MockImagesExtractor struct {
2121
mock.Mock
2222
}
2323

24-
func (m *MockImagesExtractor) ExtractFiles(scanPath string) (types.FileImages, map[string]map[string]string, string, error) {
25-
args := m.Called(scanPath)
24+
func (m *MockImagesExtractor) ExtractFiles(scanPath string, isFullHelmDirectory ...bool) (types.FileImages, map[string]map[string]string, string, error) {
25+
args := m.Called(scanPath, isFullHelmDirectory)
2626
return args.Get(0).(types.FileImages), args.Get(1).(map[string]map[string]string), args.String(2), args.Error(3)
2727
}
2828

@@ -31,6 +31,11 @@ func (m *MockImagesExtractor) ExtractAndMergeImagesFromFiles(files types.FileIma
3131
return args.Get(0).([]types.ImageModel), args.Error(1)
3232
}
3333

34+
func (m *MockImagesExtractor) ExtractAndMergeImagesFromFilesWithLineInfo(files types.FileImages, images []types.ImageModel, settingsFiles map[string]map[string]string) ([]types.ImageModel, error) {
35+
args := m.Called(files, images, settingsFiles)
36+
return args.Get(0).([]types.ImageModel), args.Error(1)
37+
}
38+
3439
func (m *MockImagesExtractor) SaveObjectToFile(folderPath string, obj interface{}) error {
3540
return m.Called(folderPath, obj).Error(0)
3641
}
@@ -128,7 +133,7 @@ func TestResolve(t *testing.T) {
128133
checkmarxPath := filepath.Join(resolutionFolderPath, ".checkmarx", "containers")
129134
createTestFolder(checkmarxPath)
130135

131-
mockImagesExtractor.On("ExtractFiles", scanPath).
136+
mockImagesExtractor.On("ExtractFiles", scanPath, mock.Anything).
132137
Return(sampleFileImages, map[string]map[string]string{"settings.json": {"key": "value"}}, "/output/path", nil)
133138
mockImagesExtractor.On("ExtractAndMergeImagesFromFiles",
134139
sampleFileImages,
@@ -141,7 +146,7 @@ func TestResolve(t *testing.T) {
141146
err := resolver.Resolve(scanPath, resolutionFolderPath, images, true)
142147
assert.NoError(t, err)
143148

144-
mockImagesExtractor.AssertCalled(t, "ExtractFiles", scanPath)
149+
mockImagesExtractor.AssertCalled(t, "ExtractFiles", scanPath, mock.Anything)
145150
mockImagesExtractor.AssertCalled(t, "ExtractAndMergeImagesFromFiles", sampleFileImages, mock.Anything, mock.Anything)
146151
mockSyftPackagesExtractor.AssertCalled(t, "AnalyzeImagesWithPlatform", mock.Anything, "linux/amd64")
147152
mockImagesExtractor.AssertCalled(t, "SaveObjectToFile", checkmarxPath, expectedResolution)
@@ -169,14 +174,14 @@ func TestResolve(t *testing.T) {
169174
checkmarxPath := filepath.Join(resolutionFolderPath, ".checkmarx", "containers")
170175
createTestFolder(checkmarxPath)
171176

172-
mockImagesExtractor.On("ExtractFiles", scanPath).
177+
mockImagesExtractor.On("ExtractFiles", scanPath, mock.Anything).
173178
Return(sampleFileImages, map[string]map[string]string{"settings.json": {"key": "value"}}, "/output/path",
174179
errors.New("invalid path"))
175180

176181
err := resolver.Resolve(scanPath, resolutionFolderPath, images, false)
177182
assert.Error(t, err)
178183
assert.Equal(t, "invalid path", err.Error())
179-
mockImagesExtractor.AssertCalled(t, "ExtractFiles", scanPath)
184+
mockImagesExtractor.AssertCalled(t, "ExtractFiles", scanPath, mock.Anything)
180185
})
181186

182187
t.Run("Error in AnalyzeImages", func(t *testing.T) {
@@ -188,7 +193,7 @@ func TestResolve(t *testing.T) {
188193
checkmarxPath := filepath.Join(resolutionFolderPath, ".checkmarx", "containers")
189194
createTestFolder(checkmarxPath)
190195

191-
mockImagesExtractor.On("ExtractFiles", scanPath).
196+
mockImagesExtractor.On("ExtractFiles", scanPath, mock.Anything).
192197
Return(sampleFileImages, map[string]map[string]string{"settings.json": {"key": "value"}}, "/output/path", nil)
193198

194199
mockImagesExtractor.On("ExtractAndMergeImagesFromFiles", sampleFileImages, types.ToImageModels(images),

0 commit comments

Comments
 (0)