Merge pull request #859 from CenterForOpenScience/release/25.2.0

Release/25.2.0 share cleanupgrade (milestone 1: simplify)

Author: aaxelb

.docker-compose.env

@@ -2,7 +2,6 @@ CELERY_BROKER_URL=amqp://guest:guest@rabbitmq:5672
 DATABASE_HOST=postgres
 ELASTICSEARCH8_URL=https://elastic8:9200/
 # ELASTICSEARCH5_URL=http://elasticsearch:9200/
-EMBER_SHARE_URL=http://frontend:4200
 LOGIN_REDIRECT_URL=http://localhost:8003/
 OSF_API_URL=http://localhost:8000
 RABBITMQ_HOST=rabbitmq

.github/workflows/run_tests.yml

@@ -14,7 +14,7 @@ jobs:
       fail-fast: false
       matrix:
         python-version: ['3.10']  # TODO: 3.11, 3.12
-        postgres-version: ['10', '15']
+        postgres-version: ['15', '17']
     runs-on: ubuntu-latest
     services:
       postgres:
@@ -49,13 +49,13 @@ jobs:
           - 5672:5672
           - 15672:15672
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: install non-py dependencies
         run: sudo apt-get update && sudo apt-get install -y libxml2-dev libxslt1-dev libpq-dev git gcc
 
       - name: set up python${{ matrix.python-version }}
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
           cache: pip
@@ -74,14 +74,15 @@ jobs:
 
       - name: run tests
         run: |
-          coverage run -m pytest -x --create-db
-          coverage run --append -m behave
+          coverage run -m pytest --create-db
+          coverage xml -o _shtrove_coverage.xml
         env:
           DATABASE_PASSWORD: postgres
           ELASTICSEARCH8_URL: http://localhost:9208/
           # ELASTICSEARCH5_URL: http://localhost:9205/
 
       - name: coveralls
-        uses: coverallsapp/github-action@v2.3.0
+        uses: coverallsapp/github-action@v2
         with:
-          coverage-reporter-version: v0.6.9  # avoid broken v0.6.10 -- see https://github.com/coverallsapp/github-action/issues/205
+          file: _shtrove_coverage.xml
+          fail-on-error: false

CHANGELOG.md

@@ -1,5 +1,42 @@
 # Change Log
 
+# [25.2.0] - 2025-05-05
+- further move on from SHAREv2...
+- delete sharev2 ingestion pipeline
+    - share/harvest/*
+    - share/harvesters/*
+    - share/metadata_formats/*
+    - share/regulate/*
+    - share/schema/*
+    - share/sources/*
+    - share/tasks/*
+        - except `schedule_index_backfill` -- moved to `share.models.index_backfill` for now
+    - share/transform/*
+    - share/transformers/*
+    - anything deactivated by the `ignore_sharev2_ingest` feature flag
+- delete (some) sharev2 db models/tables from share/models/...
+    - core.py: NormalizedData, FormattedMetadataRecord
+    - jobs.py: HarvestJob
+    - registration.py: ProviderRegistration
+    - sources.py: SourceStat
+- delete (some) sharev2 api
+    - /api/v2/formattedmetadatarecords/...
+    - /api/v2/normalizeddata/...
+        - note: sharev2 “push” is a POST to this endpoint -- replaced by /trove/ingest
+    - /api/v2/sourceregistrations/...
+    - /api/v2/schemas/...
+    - /api/v1/share/data
+- delete `sharectl` (share/bin/*)
+    - prefer django management commands, for now
+- add management commands
+    - shtrove_indexer_run (replaces `sharectl search daemon`)
+    - shtrove_search_setup (replaces `sharectl search setup`)
+    - shtrove_search_teardown (replaces `sharectl search purge`)
+    - delete_pretrove_data (for letting go of some past)
+- remove special ember-share handling (for local dev)
+- remove all dead code and requirements easily removed
+- update github actions flow (with more accurate code coverage)
+
 # [25.1.1] - 2025-03-04
 - reduce wasteful text-field indexing (better this time)
 - on the share-admin search-indexes page:

api/base/views.py

@@ -45,12 +45,9 @@ def initial(self, request, *args, **kwargs):
 class RootView(views.APIView):
     def get(self, request):
         links = {
-            'normalizeddata': 'api:normalizeddata-list',
             'rawdata': 'api:rawdatum-list',
-            'sourceregistrations': 'api:sourceregistration-list',
             'sources': 'api:source-list',
             'users': 'api:user-list',
-            'schema': 'api:schema',
             'status': 'api:status',
             'rss': 'api:rss',
             'atom': 'api:atom',