Skip to content

Set exact max factor in multiplication #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set exact max factor in multiplication #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ Default: -2894802230932904885589274625217197696331749616641014100986439600197828
Maximum value that can be safely used as a multiplication operator.
Divisions where a value is divided by another over this value might overflow,
but not necessarily so.
Calculated as maxFixedMul() = sqrt(maxNewFixed())*fixed1().
Default: 240615969168004511545000000000000000000000000000000000000
Calculated as maxFixedMul() = sqrt(maxNewFixed()*fixed1()).
Default: 240615969168004511545033772477625056927114980741063

**function maxFixedDiv() public pure returns(int256)**
Maximum value that can be safely used as a dividend.
Expand Down
2 changes: 1 addition & 1 deletion contracts/FixidityLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ library FixidityLib {
* Hardcoded to 24 digits.
*/
function maxFixedMul() public pure returns(int256) {
return 240615969168004498257251713877715648331380787511296;
return 240615969168004511545033772477625056927114980741063;
}

/**
Expand Down