Skip to content

Conversation

@rudera-byte
Copy link

@rudera-byte rudera-byte commented Mar 13, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Issue #1162

TESSDATA_PREFIX is an environment variable that points to the directory/folder containing the tessdata directory/folder. For some reason, ccextractor requires TESSDATA_PREFIX to finish with a /. It should work without one. So I added a conditional check to include a / if it is not there.

@steel-bucket
Copy link
Contributor

Hi, the regression tests are all failing. Can you please rebase so we can know more.
Thanks

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 42d7509...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hardsubx 1/1
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 86/86
Teletext 21/21
WTV 13/13
XDS 34/34

Congratulations: Merging this PR would fix the following tests:


All tests passing on the master branch were passed completely.

Check the result page for more info.

@rudera-byte
Copy link
Author

Hello, I have rebased, and it still fails specifically for Windows. The errors are caused by a Windows dependency issue unrelated to my code.

@steel-bucket
Copy link
Contributor

Yes, that error has halted development for a few weeks now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants