Pagination refactor #48
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Firstly, thanks for wonderful library! Just the right amount of features while staying small. I also found the code to be very clearly written.
I found that the pagination implementation doesn't work when using filtering and sorting as they don't operate on the original rows. I did quite a large refactor which, for all of sorting, filtering and search, goes through the whole process on the original rows of original -> sorted -> filtered -> searched -> paginated.
It seems to be working correctly for me, but unfortunately I don't have the time right now to look at the tests and making new ones for the cases which were not working before/are now possible.
Combined with the fact this is a huge change, I imagine this PR won't be accepted, but I thought I'd leave it here anyway in case anyone wishes to continue with it or use it in it's current state.