diff --git a/DESCRIPTION b/DESCRIPTION index 6e2a377..85a359b 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -3,7 +3,7 @@ Title: Standard styles for vignettes and other Bioconductor documents Description: Provides standard formatting styles for Bioconductor PDF and HTML documents. Package vignettes illustrate use and functionality. -Version: 2.29.0 +Version: 2.29.1 Authors@R: c( person("Andrzej", "Oleś", role = "aut", comment = c(ORCID = "0000-0003-0285-2787") diff --git a/NEWS b/NEWS index 8e78cc5..cf9cd13 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,11 @@ +CHANGES IN VERSION 2.30.0 + +BUG FIXES + + o BiocStyle no longer breaks Javascript inserted by the Glimma package to + produce interactive plots. + (https://github.com/Bioconductor/BiocStyle/issues/97) + CHANGES IN VERSION 2.28.0 ------------------------ diff --git a/R/html_document.R b/R/html_document.R index 8ef0dab..bd269c2 100644 --- a/R/html_document.R +++ b/R/html_document.R @@ -294,8 +294,14 @@ process_footnotes = function(lines) { ## We wrap tables in a
so they can fill the screen on mobile ## but also scroll if they overflow horizontally process_tables = function(lines) { - lines = gsub("", "
", lines, fixed = TRUE) + + ## this will inadvertently mess up some javascript e.g. from Glimma + ## so we only modify the body of the html + body_start = grep(pattern = "", x = lines, fixed = TRUE) + body_end = grep(pattern = "", x = lines, fixed = TRUE) + + lines[body_start:body_end] = gsub("", "", lines[body_start:body_end], fixed = TRUE) lines }