Appending .db to the file name

[martin-ecatch]

Hi @BingCoke,
great work on this adapter! I was going to test it and encountered this unexpected behaviour:
The sqlite database name is forced to end with ".db". I have some existing databases from the original plugin and they all have ".sqlite" extension. Looking at the source code, it seems like op-sqlite does that. My app runs mainly offline so needs to handle upgrades seamlessly.
Do you feel strongly about forcing .db extension? I suggest removing this line and just passing options.name to op-sqlite:

pouchdb-adapter-sqlite/packages/pouchdb-adapter-opsqlite/src/opsqlite-adapter.ts

Line 130 in 0ca7b5d

const dbName = options.name.endsWith('.db') ? options.name : `${options.name}.db`;

Cheers!

[BingCoke]

Thank you for your feedback—the issue has been resolved. Could you please install the latest version when you have a moment?

Let me know if you encounter any further issues.

[martin-ecatch]

Thanks for the quick response!
After some debugging, I found out that the issue goes deeper - into the "core" package.

pouchdb-adapter-sqlite/packages/pouchdb-adapter-sqlite-core/src/core.ts

Line 176 in fec8931

const sqlOpts = Object.assign({}, opts, { name: opts.name + '.db' });

I looked at the original craftzdog's plugin and it appends '.sqlite' in that line:
https://github.com/craftzdog/pouchdb-adapter-react-native-sqlite/blob/95728ab1b3149a7131e5526f5b03817f5589be3f/src/core.ts#L99

This makes it difficult to migrate from craftzdog's original plugin. Is it too late to change it back to '.sqlite'? Another option is to make it a configurable property. What do you think?

[martin-ecatch]

Oh and one more unrelated thing that I found. The documentation says to use "sqliteImplementation: 'op-sqlite'", but it's actually just 'opsqlite' without the dash:
db = new PouchDB(
...,
{
adapter: 'sqlite',
sqliteImplementation: 'opsqlite',
})

pouchdb-adapter-sqlite/packages/pouchdb-adapter-opsqlite/src/index.ts

Line 20 in fec8931

PouchDB.registerSQLiteImplementation('opsqlite', opsqliteFactory);

[BingCoke]

Got it. You can submit a PR to address this issue by adding an option for SQLite file extensions, and don’t forget to include a default setting.