Skip to content

Commit 6900f76

Browse files
committed
feat: opt
1 parent 5dbbbe5 commit 6900f76

File tree

3 files changed

+20
-30
lines changed

3 files changed

+20
-30
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "echarts-next-for-react",
3-
"version": "1.1.0",
3+
"version": "1.1.1",
44
"description": "Echarts(v5.x | next) components for react.",
55
"main": "dist/index.js",
66
"module": "dist/index.esm.js",

src/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ const EChartsNextForReactCore: FC<EChartsNextForReactCoreProps> = (props) => {
5050
onEvents,
5151
renderType = 'canvas',
5252
} = props;
53-
// coordinateSystem 'polar': PolarComponent
5453

5554
const isCanvas = renderType === 'canvas';
5655

src/utils/index.ts

Lines changed: 19 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import isEmpty from 'lodash/isEmpty';
2-
import isObject from 'lodash/isObject';
2+
import isArray from 'lodash/isArray';
33
import {
44
BarChart,
55
BoxplotChart,
@@ -62,18 +62,10 @@ import { CanvasRenderer, SVGRenderer } from 'echarts/renderers';
6262
import type { EChartsOption } from 'echarts';
6363

6464
const enableComponentBySeriesType = (series: object | any[], type: any) =>
65-
isObject(series)
66-
? // @ts-ignore
67-
series?.type === type
68-
: // @ts-ignore
69-
series?.length > 0 && !!series?.find((v) => v.type === type);
65+
(isArray(series) ? series : [series]).find(({ type: t }) => t === type);
7066

7167
const enableComponentBySeriesProp = (series: object | any[], prop: any) =>
72-
isObject(series)
73-
? // @ts-ignore
74-
series?.[prop]
75-
: // @ts-ignore
76-
series?.length > 0 && !!series?.map(v.prop);
68+
(isArray(series) ? series : [series]).map((v) => v[prop]);
7769

7870
export const getRegisterComponents = (option: EChartsOption, isCanvas: boolean) => {
7971
// necessary Component
@@ -120,11 +112,10 @@ export const getRegisterComponents = (option: EChartsOption, isCanvas: boolean)
120112
}
121113
// register polar Component
122114
if (
123-
polar &&
124-
// @ts-ignore
125-
((isObject(series) && series?.coordinateSystem === 'polar') ||
126-
// @ts-ignore
127-
(series?.length > 0 && series?.find((v) => v.coordinateSystem === 'polar')))
115+
polar ||
116+
!!(isArray(series) ? series : [series]).find(
117+
({ coordinateSystem }) => coordinateSystem === 'polar',
118+
)
128119
) {
129120
registerComponents = [PolarComponent, ...registerComponents];
130121
}
@@ -178,20 +169,20 @@ export const getRegisterComponents = (option: EChartsOption, isCanvas: boolean)
178169
}
179170
// register geo Component
180171
if (
181-
geo || // @ts-ignore
182-
(isObject(series) && series?.coordinateSystem === 'geo') ||
183-
// @ts-ignore
184-
(series?.length > 0 && series?.find((v) => v.coordinateSystem === 'geo'))
172+
geo ||
173+
!!(isArray(series) ? series : [series]).find(
174+
({ coordinateSystem }) => coordinateSystem === 'geo',
175+
)
185176
) {
186177
registerComponents = [GeoComponent, ...registerComponents];
187178
}
188179
// register parallel Component
189180
if (
190181
parallel ||
191182
enableComponentBySeriesType(series, 'parallel') || // @ts-ignore
192-
(isObject(series) && series?.coordinateSystem === 'parallel') ||
193-
// @ts-ignore
194-
(series?.length > 0 && series?.find((v) => v.coordinateSystem === 'parallel'))
183+
!!(isArray(series) ? series : [series]).find(
184+
({ coordinateSystem }) => coordinateSystem === 'parallel',
185+
)
195186
) {
196187
registerComponents = [ParallelChart, ParallelComponent, ...registerComponents];
197188
}
@@ -224,7 +215,11 @@ export const getRegisterComponents = (option: EChartsOption, isCanvas: boolean)
224215
// register components by series
225216
// register line component
226217
if (enableComponentBySeriesType(series, 'line')) {
227-
registerComponents = [LinesChart, LineChart, ...registerComponents];
218+
registerComponents = [LineChart, LinesChart, ...registerComponents];
219+
}
220+
// register lines component
221+
if (enableComponentBySeriesType(series, 'lines')) {
222+
registerComponents = [LineChart, LinesChart, ...registerComponents];
228223
}
229224
// register bar component
230225
if (enableComponentBySeriesType(series, 'bar')) {
@@ -270,10 +265,6 @@ export const getRegisterComponents = (option: EChartsOption, isCanvas: boolean)
270265
if (enableComponentBySeriesType(series, 'map')) {
271266
registerComponents = [MapChart, ...registerComponents];
272267
}
273-
// register lines component
274-
if (enableComponentBySeriesType(series, 'lines')) {
275-
registerComponents = [LineChart, LinesChart, ...registerComponents];
276-
}
277268
// register sankey component
278269
if (enableComponentBySeriesType(series, 'sankey')) {
279270
registerComponents = [SankeyChart, ...registerComponents];

0 commit comments

Comments
 (0)