Drops explicit cleanup on del (#88)

Author: djperrefort

keystone_client/http.py

@@ -7,7 +7,6 @@
 """
 
 import abc
-import asyncio
 import re
 import uuid
 from typing import Optional, Union
@@ -115,9 +114,6 @@ def __enter__(self) -> 'HTTPClient':
     def __exit__(self, exc_type, exc_val, exc_tb) -> None:
         self.close()
 
-    def __del__(self) -> None:
-        self.close()
-
     def _client_factory(self, **kwargs) -> httpx.Client:
         """Create a new HTTP client instance with the provided settings."""
 
@@ -271,14 +267,6 @@ async def __aenter__(self) -> 'AsyncHTTPClient':
     async def __aexit__(self, exc_type, exc_val, exc_tb) -> None:
         await self.close()
 
-    def __del__(self) -> None:
-        try:
-            loop = asyncio.get_running_loop()
-            loop.create_task(self._client.aclose())
-        except RuntimeError:
-            # No running loop; can't close asynchronously
-            pass
-
     def _client_factory(self, **kwargs) -> httpx.AsyncClient:
         """Create a new HTTP client instance with the provided settings."""
 

tests/unit_tests/test_http/test_AsyncHTTPClient.py

@@ -33,16 +33,6 @@ async def test_close_on_exit(self, mock_httpx_class: MagicMock) -> None:
 
         mock_httpx_class.return_value.aclose.assert_called_once()
 
-    async def test_close_on_delete(self, mock_httpx_class: MagicMock) -> None:
-        """Verify any open sessions are closed when deleting an instance."""
-
-        mock_httpx_class.return_value.aclose = AsyncMock()
-
-        client = AsyncHTTPClient(base_url="https://example.com")
-        del client
-
-        mock_httpx_class.return_value.aclose.assert_called_once()
-
 
 class SendRequestMethodAsync(IsolatedAsyncioTestCase):
     """Test HTTP requests issued by the `send_requests` method."""

tests/unit_tests/test_http/test_HTTPClient.py

@@ -29,14 +29,6 @@ def test_close_on_exit(self, mock_httpx_class: MagicMock) -> None:
 
         mock_httpx_class.return_value.close.assert_called_once()
 
-    def test_close_on_delete(self, mock_httpx_class: MagicMock) -> None:
-        """Verify any open sessions are closed when deleting an instance."""
-
-        client = HTTPClient(base_url="https://example.com")
-        del client
-
-        mock_httpx_class.return_value.close.assert_called_once()
-
 
 class SendRequestMethod(TestCase):
     """Test HTTP requests issued by the `send_requests` method."""