optimizing req URL parsing

Author: jkyberneees

lib/router/sequential.js

@@ -1,4 +1,5 @@
 const Trouter = require('trouter')
+const qs = require('fast-querystring')
 const next = require('./../next')
 
 const status404 = {
@@ -36,10 +37,13 @@ module.exports = (config = {}) => {
   }
 
   router.fetch = (req) => {
-    const url = new URL(req.url)
+    const url = req.url
+    const startIndex = url.indexOf('/', 11)
+    const queryIndex = url.indexOf('?', startIndex + 1)
+    const path = queryIndex === -1 ? url.substring(startIndex) : url.substring(startIndex, queryIndex)
 
-    req.path = url.pathname || '/'
-    req.query = url.queryparams
+    req.path = path || '/'
+    req.query = queryIndex > 0 ? qs.parse(url.substring(queryIndex + 1)) : {}
 
     const match = router.find(req.method, req.path)
     if (match.handlers.length > 0) {

package-lock.json

@@ -8,6 +8,7 @@
     "format": "bun x standard --fix"
   },
   "dependencies": {
+    "fast-querystring": "^1.1.2",
     "trouter": "^3.2.1"
   },
   "repository": {
@@ -21,7 +22,7 @@
     "lib/"
   ],
   "devDependencies": {
-    "0http-bun": "^1.0.0",
+    "0http-bun": "^1.0.2",
     "mitata": "^0.1.11"
   },
   "keywords": [

package.json

@@ -17,6 +17,10 @@ describe('Router', () => {
       return Response.json(req.params)
     })
 
+    router.get('/qs', (req) => {
+      return Response.json(req.query)
+    })
+
     router.delete('/get-params/:id', () => {
       return Response.json('OK')
     })
@@ -83,4 +87,12 @@ describe('Router', () => {
     expect(response.status).toBe(200)
     expect(await response.json()).toEqual({ engine: 'bun' })
   })
+
+  it('should return a JSON response with the query string parameters', async () => {
+    const response = await router.fetch(new Request('http://localhost:3000/qs?foo=bar', {
+      method: 'GET'
+    }))
+    expect(response.status).toBe(200)
+    expect(await response.json()).toEqual({ foo: 'bar' })
+  })
 })