[Koin Project][refactor] 설정 화면 composing UI 부분 #1044

KYM-P · 2025-09-24T16:39:58Z

PR 개요

이슈 번호: #1042

PR 체크리스트

Code convention을 잘 지켰나요?
Lint check를 수행하였나요?
Assignees를 추가했나요?

작업사항

작업사항의 상세한 설명

ui 부분만 만들었습니다.
내부에 많은 세부 화면이 존재하는데
이 부분은 각각 브랜치를 파서 작업하겠습니다.

또한 setting viewModel 과 붙이는 작업도 다른 PR 에 올릴 예정입니다.

논의 사항

version 비교 text 가 어떻게 작동하는질 잘 모르겠네요.
시뮬레이션 환경에서는 보여주고
실제 앱에서는 안보이며 버전에 차이가 날 때에만 표시되는 것 같은데...
아직 제가 원본 코드를 안본 것도 있는데 혹시 아시는 분은 알려주세요.

스크린샷

기존	개편

추가내용

develop, sprint 브랜치를 향하고 있습니다
production 브랜치를 향하고 있습니다

Add feature setting module

Create setting screen

kongwoojin

고생하셨습니다.
lint 먼저 수정해주세요

kongwoojin · 2025-09-25T07:22:10Z

feature/setting/src/main/java/in/koreatech/koin/feature/setting/component/SettingItem.kt

+        modifier = Modifier
+            .fillMaxWidth()
+            .background(color = backgroundColor)
+            .padding(vertical = 13.dp, horizontal = 24.dp)


음? 13이요?

figma 는 16 인데
16 으로 하면 기존 설정 화면 대비 매우 커집니다...
일단 수작업으로 조사하면서 가장 알맞은 값을 넣었습니다.

kongwoojin · 2025-09-25T07:25:02Z

feature/setting/src/main/java/in/koreatech/koin/feature/setting/ui/SettingScreen.kt

+                onNavigationIconClick = onTopbarBackClick
+            )
+        },
+        contentWindowInsets = WindowInsets(0, 0, 0, 0)


insets을 확장했는데, 다른 곳에 insets 처리를 한 코드가 없는 것 같습니다

Add padding insets and navigation bar padding

Feat ktlint

KYM-P · 2025-09-28T06:45:10Z

`navigationbarPadding` 과 `cunsumeInsets` 를 적용했습니다.

chore: Change SettingItem and VersionItem parameter name

feature: Connect SettingViewModel and screen

feature: Add contact click event

Feat ktlint

Change Text in m3 to BasicText

Add google oss licenses lib

Add term page and oss licenses page

Feat ktlint

Delete funtion's unusable lamda

Change URL.kt name to URLConstant.kt

Add Navigation extensions 'goToUrl'

…m/BCSDLab/KOIN_ANDROID into refactor/setting-opensource-marketing

KYM-P · 2025-10-06T15:49:46Z

Merged #1084
주요 내용 : core/Navigation/Extensions.kt 에 goToUrl 추가
Intent.ACTION_VIEW 가 기본 parameter 로 존재

Add import Intent

kongwoojin

고생하셨습니다.
코멘트 확인해주세요

kongwoojin · 2025-10-06T15:54:11Z

core/navigation/src/main/java/in/koreatech/koin/core/navigation/utils/Extensions.kt

        putExtras(bundleOf(*argument))
    }

+fun Context.goToUrl(uri: Uri, action: String = Intent.ACTION_VIEW, vararg argument: Pair<String, Any?>) {


오.. 전역적인 확장함수가 아니라 딱 문의하기로 넘어가는 것을 말한거였습니다

그러면 core/Navigator 에서 선언하고 koin/NavigatiorImpl 에 구현하는 방식으로 갈까요?
navigateToContact 가 될 거 같네요. intent 를 생성하는 함수로

Navigator는 내부 화면들끼리 이동하는 함수이니 그냥 ContextUtil 하나 만들어서 처리하면 될 것 같습니다

갑자기 생각난점 확장 함수를 어디다 둬야할까요.
재사용성을 위해 확장함수를 만드는 부분인데 Navigator 은 내부 화면 이동을 위해 넣기 애매합니다.
그냥 feature 에 util 로 넣자니 재사용이 setting 에서만 가능하구요.
그냥 Navigator/Extensions 에 넣을까요? 지금처럼

그냥 core에 넣으면 될 것 같습니다

kongwoojin · 2025-10-06T15:54:42Z

feature/setting/src/main/java/in/koreatech/koin/feature/setting/component/SettingItem.kt

+        )
+        if (showIcon) {
+            Icon(
+                painter = painterResource(R.drawable.ic_arrow_right),


ImageVector 사용해주세요

https://developer.android.com/develop/ui/compose/graphics/images/compare?hl=ko
그냥 painter 를 써도 vector 이미지면 자동으로 vectorImage 를 통해 그려 주는 거 같습니다.
밑에 ImageVector.vectorResource 를 사용해서 vectorImage 로 주는 게 있긴 한데
Icon(vectorImage = ) 살짝 뜯어보니 결국 내부에서 다시 Icon(painter =) 호출하는 거 보면 그냥 써도 문제 없을 거 같습니다.

feature/setting/src/main/java/in/koreatech/koin/feature/setting/component/SettingItem.kt

feature/setting/src/main/java/in/koreatech/koin/feature/setting/component/SettingTitle.kt

kongwoojin · 2025-10-06T15:57:40Z

feature/setting/src/main/java/in/koreatech/koin/feature/setting/ui/SettingScreen.kt

+@OptIn(ExperimentalMaterial3Api::class)
+@Composable
+fun SettingScreen(
+    viewModel: SettingViewModel = hiltViewModel(),


여기도요

kongwoojin · 2025-10-06T16:00:56Z

feature/setting/src/main/java/in/koreatech/koin/feature/setting/ui/SettingScreen.kt

+    Column(
+        modifier = modifier
+            .fillMaxSize()
+            .navigationBarsPadding()


Scaffold의 KoinTopAppBar에서 status bar insets을 처리하고 있어 문제가 되지 않지만, 실제로 SettingScreenImpl에는 navigation bar insets만 적용이 된 상태입니다.
이렇게 되면 KoinTopAppBar가 사라질 경우, status bar와 content가 겹치는 문제가 생길 수 있습니다.
따라서 systemBarsPadding() 사용을 권장합니다.

어차피 상위 컴포넌트에서 status bar insets을 소비했기 때문에 적용되지 않으니깐요

kongwoojin · 2025-10-06T16:02:04Z

feature/setting/src/main/java/in/koreatech/koin/feature/setting/ui/SettingScreen.kt

+            .fillMaxSize()
+            .navigationBarsPadding()
+            .padding(contentPadding)
+            .consumeWindowInsets(contentPadding)


navigation bar insets도 소비 처리를 해줘야 할 것 같습니다.

아닌가 생각해보니 navigationBarsPadding()가 소비 처리를 해줬던 것 같네요
확인 후 작업 부탁드려요

expect fun Modifier.navigationBarsPadding(): Modifier 뜯어보니
주석에 | When used, the WindowInsets will be consumed. 이 있네요 소비되는 거 같습니다.

Delete contentPadding parameter

Add notification string resource

Add NorificationSwitchItem component

Add notification menu string resource

…-osslisenses [Koin Project][Refactor] setting 내부 Term(약관) 화면 + ossLicenses(오픈소스) 화면 추가

Add notification itme and switchsubitem components

Add notification screen

Connect setting screen and notification screen

Add component padding

Feat ktlint

Change notification appbar text

Add notification viewmodel

Add login snackbar

…ub.com/BCSDLab/KOIN_ANDROID into refactor/setting-notification

Feat ktlint

…ub.com/BCSDLab/KOIN_ANDROID into refactor/setting-notification

Feat ktlint

…ub.com/BCSDLab/KOIN_ANDROID into refactor/setting-notification

Connect screen and viewmodel

Feat ktlint

…tion-ui [Koin Project][Refactor] 알림 설정 ui 구현 + login snackbar 추가

Delete URLConstant object

Delete Init permitted variable and Add isTypePermitted util

Fix unmatched type

Feat ktlint

kongwoojin

고생하셨습니다.
회의때 이야기 할게 있어서 회의때 이야기 해보고 머지하면 될 것 같습니다

kongwoojin · 2025-10-25T09:46:06Z

...rc/main/java/in/koreatech/koin/feature/setting/ui/notification/component/NotificationItem.kt

+            .clickable {
+                onClick()
+            }


Suggested change

.clickable {

onClick()

}

clickable(onClick = onClick)

이렇게도 가능할 것 같습니다

Apply fastForEach

…tion [Koin Project][Refactor] setting 에 notification 의 기능적 부분 구현

Remove useless lambda in modifier clickable

Feat ktlint

…-onclick [Koin Project][refactor] Modifier 에 clickable 로 불필요한 lambda 의 제거

KYM-P added 2 commits September 25, 2025 01:31

feature: Add feature setting module

e0660d2

Add feature setting module

feature: Create setting screen

99ea7db

Create setting screen

KYM-P requested a review from a team as a code owner September 24, 2025 16:39

github-actions bot added the refactor Code refactoring label Sep 24, 2025

github-actions bot requested review from JaeYoung290 and TTRR1007 September 24, 2025 16:40

KYM-P changed the title ~~Refactor/#1042 setting compose UI~~ [Koin Project][refactor] 설정 화면 composing UI 부분 Sep 24, 2025

github-actions bot added the koin project label Sep 24, 2025

KYM-P self-assigned this Sep 24, 2025

KYM-P linked an issue Sep 24, 2025 that may be closed by this pull request

[Koin Project] 설정 화면 리펙토링 #1042

Open

1 task

kongwoojin requested changes Sep 25, 2025

View reviewed changes

KYM-P added 2 commits September 28, 2025 15:37

chore : Add padding insets and navigation bar padding

7626532

Add padding insets and navigation bar padding

chore: Feat ktlint

690a8dc

Feat ktlint

KYM-P added 12 commits October 6, 2025 17:45

chore: Change SettingItem and VersionItem parameter name

0021122

chore: Change SettingItem and VersionItem parameter name

feature: Connect SettingViewModel and screen

cf1959b

feature: Connect SettingViewModel and screen

feature: Add contact click event

35190d8

feature: Add contact click event

chore: Feat ktlint

436eb25

Feat ktlint

featrue: Change Text in m3 to BasicText

50e5a38

Change Text in m3 to BasicText

feature: Add google oss licenses lib

a542a82

Add google oss licenses lib

feature: Add term page and oss licenses page

457ef3d

Add term page and oss licenses page

chore: Feat ktlint

b447ca7

Feat ktlint

chore: Delete funtion's unusable lamda

0e5e516

Delete funtion's unusable lamda

chore: Change URL.kt name to URLConstant.kt

6fe7a81

Change URL.kt name to URLConstant.kt

feature: Add Navigation extensions 'goToUrl'

bd1d097

Add Navigation extensions 'goToUrl'

Merge branch 'refactor/#1042-setting-compose-ui' of https://github.co…

71f2bfd

…m/BCSDLab/KOIN_ANDROID into refactor/setting-opensource-marketing

fix: Add import Intent

e43fb19

Add import Intent

kongwoojin requested changes Oct 6, 2025

View reviewed changes

chore: Delete contentPadding parameter

dca7df5

Delete contentPadding parameter

KYM-P and others added 24 commits October 9, 2025 14:43

feature: Add notification string resource

93a12fb

Add notification string resource

feature: Add NorificationSwitchItem component

c40e7e0

Add NorificationSwitchItem component

feature: Add notification menu string resource

557d908

Add notification menu string resource

Merge pull request #1093 from BCSDLab/refactor/#1042-setting-term-and…

38b8af7

…-osslisenses [Koin Project][Refactor] setting 내부 Term(약관) 화면 + ossLicenses(오픈소스) 화면 추가

feature: Add notification itme and switchsubitem components

a03a38a

Add notification itme and switchsubitem components

feature: Add notification screen

6cb39f1

Add notification screen

feature: Connect setting screen and notification screen

810e445

Connect setting screen and notification screen

chore: Add component padding

c18cfc0

Add component padding

chore: Feat ktlint

f7add57

Feat ktlint

fix: Change notification appbar text

b1e49eb

Change notification appbar text

chore: Add notification viewmodel

ae7541b

Add notification viewmodel

feature: Add login snackbar

e4a8959

Add login snackbar

Merge branch 'refactor/#1042-setting-notification-ui' of https://gith…

f501bb0

…ub.com/BCSDLab/KOIN_ANDROID into refactor/setting-notification

chore: Feat ktlint

54533ab

Feat ktlint

Merge branch 'refactor/#1042-setting-notification-ui' of https://gith…

f96d581

…ub.com/BCSDLab/KOIN_ANDROID into refactor/setting-notification

chore: Feat ktlint

a097ecb

Feat ktlint

Merge branch 'refactor/#1042-setting-notification-ui' of https://gith…

75071b2

…ub.com/BCSDLab/KOIN_ANDROID into refactor/setting-notification

feature: Connect screen and viewmodel

73323aa

Connect screen and viewmodel

chore: Feat ktlint

869382c

Feat ktlint

Merge pull request #1095 from BCSDLab/refactor/#1042-setting-notifica…

b7f0821

…tion-ui [Koin Project][Refactor] 알림 설정 ui 구현 + login snackbar 추가

chore: Delete URLConstant object

2f68241

Delete URLConstant object

chore: Delete Init permitted variable and Add isTypePermitted util

df8bd10

Delete Init permitted variable and Add isTypePermitted util

fix: Fix unmatched type

4dabc23

Fix unmatched type

chore: Feat ktlint

045bd17

Feat ktlint

kongwoojin approved these changes Oct 25, 2025

View reviewed changes

KYM-P added 5 commits October 27, 2025 11:24

feature: Apply fastForEach

8f04f16

Apply fastForEach

Merge pull request #1098 from BCSDLab/refactor/#1042-setting-notifica…

1230a0a

…tion [Koin Project][Refactor] setting 에 notification 의 기능적 부분 구현

refactor: Remove useless lambda in modifier clickable

a18eb2f

Remove useless lambda in modifier clickable

chore: Feat ktlint

ef3f95c

Feat ktlint

Merge pull request #1126 from BCSDLab/refactor/#1042-setting-modifier…

9abc59a

…-onclick [Koin Project][refactor] Modifier 에 clickable 로 불필요한 lambda 의 제거

[Koin Project][refactor] 설정 화면 composing UI 부분 #1044

Are you sure you want to change the base?

[Koin Project][refactor] 설정 화면 composing UI 부분 #1044

Uh oh!

Conversation

KYM-P commented Sep 24, 2025

PR 개요

PR 체크리스트

작업사항

작업사항의 상세한 설명

논의 사항

스크린샷

추가내용

Uh oh!

kongwoojin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KYM-P commented Sep 28, 2025

navigationbarPadding 과 cunsumeInsets 를 적용했습니다.

Uh oh!

KYM-P commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kongwoojin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KYM-P Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kongwoojin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

`navigationbarPadding` 과 `cunsumeInsets` 를 적용했습니다.

KYM-P commented Oct 6, 2025 •

edited

Loading

KYM-P Oct 7, 2025 •

edited

Loading