Refactor ansible-playbook command construction for improved readability

Author: devanshjainms

scripts/sap_automation_qa.sh

@@ -377,8 +377,7 @@ run_ansible_playbook() {
     if [[ "$OFFLINE_MODE" == "true" ]]; then
         log "INFO" "Offline mode: Skipping SSH authentication setup"
         command="ansible-playbook ${cmd_dir}/../src/$playbook_name.yml -i $system_hosts \
-            -e @$VARS_FILE -e @$system_params -e '_workspace_directory=$system_config_folder' \
-            -e $extra_vars --connection=local"
+            -e @$VARS_FILE -e @$system_params -e '_workspace_directory=$system_config_folder' $extra_vars --connection=local"
     else
         # Set local secret_id and key_vault_id if defined
         local secret_id=$(grep "^secret_id:" "$system_params" | awk '{split($0,a,": "); print a[2]}' | xargs || true)
@@ -402,8 +401,7 @@ run_ansible_playbook() {
                 check_file_exists "$temp_file" \
                     "Temporary SSH key file not found. Please check the Key Vault secret ID."
                 command="ansible-playbook ${cmd_dir}/../src/$playbook_name.yml -i $system_hosts --private-key $temp_file \
-                    -e @$VARS_FILE -e @$system_params -e '_workspace_directory=$system_config_folder' \
-                    -e $extra_vars"
+                    -e @$VARS_FILE -e @$system_params -e '_workspace_directory=$system_config_folder' $extra_vars"
             else
                 local ssh_key_dir="${cmd_dir}/../WORKSPACES/SYSTEM/$SYSTEM_CONFIG_NAME"
                 local ssh_key=""
@@ -435,8 +433,7 @@ run_ansible_playbook() {
 
                 chmod 600 "$ssh_key"
                 command="ansible-playbook ${cmd_dir}/../src/$playbook_name.yml -i $system_hosts --private-key $ssh_key \
-                    -e @$VARS_FILE -e @$system_params -e '_workspace_directory=$system_config_folder' \
-                    -e $extra_vars"
+                    -e @$VARS_FILE -e @$system_params -e '_workspace_directory=$system_config_folder' $extra_vars"
             fi
 
         elif [[ "$auth_type" == "VMPASSWORD" ]]; then
@@ -450,14 +447,14 @@ run_ansible_playbook() {
                     "Temporary password file not found. Please check the Key Vault secret ID."
                 command="ansible-playbook ${cmd_dir}/../src/$playbook_name.yml -i $system_hosts \
                     --extra-vars 'ansible_ssh_pass=$(cat $temp_file)' --extra-vars @$VARS_FILE -e @$system_params \
-                    -e '_workspace_directory=$system_config_folder' -e $extra_vars"
+                    -e '_workspace_directory=$system_config_folder' $extra_vars"
             else
                 local password_file="${cmd_dir}/../WORKSPACES/SYSTEM/$SYSTEM_CONFIG_NAME/password"
                 check_file_exists "$password_file" \
                     "password file not found in WORKSPACES/SYSTEM/$SYSTEM_CONFIG_NAME directory."
                 command="ansible-playbook ${cmd_dir}/../src/$playbook_name.yml -i $system_hosts \
                     --extra-vars 'ansible_ssh_pass=$(cat $password_file)' --extra-vars @$VARS_FILE -e @$system_params \
-                    -e '_workspace_directory=$system_config_folder' -e $extra_vars"
+                    -e '_workspace_directory=$system_config_folder' $extra_vars"
             fi
 
         else