Skip to content

Conversation

@annacmc
Copy link
Contributor

@annacmc annacmc commented Dec 4, 2025

Proposed changes:

  • Add new SegmentedBar component for displaying horizontal segmented progress bars
  • Supports proportional and equal-width segment modes
  • Includes marker indicator for showing target/threshold positions
  • Tooltips, custom colors, and label formatting support

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No, it does not.

Testing instructions:

SegmentedBar Component:

  1. Go to Storybook -> JS Packages -> Charts -> Types -> Segmented Bar
  2. Test all three stories: Default, EqualMode, WithMarker
  3. Use Storybook controls to explore different configurations:
    • Toggle between proportional and equal modes
    • Adjust height, gap, borderRadius
    • Enable/disable tooltips and labels
    • Add/configure marker indicator
  4. Verify responsive behavior at different container widths

@annacmc annacmc added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. labels Dec 4, 2025
@annacmc annacmc self-assigned this Dec 4, 2025
@annacmc annacmc requested a review from Copilot December 4, 2025 04:29
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/new-chart-categorybar branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/new-chart-categorybar

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copilot finished reviewing on behalf of annacmc December 4, 2025 04:33

This comment was marked as outdated.

@jp-launch-control
Copy link

jp-launch-control bot commented Dec 4, 2025

Code Coverage Summary

3 files are newly checked for coverage.

File Coverage
projects/js-packages/charts/src/components/segmented-bar/segmented-bar.tsx 71/79 (89.87%) 💚
projects/js-packages/charts/src/components/segmented-bar/index.ts 0/0 (—%) 🤷

Full summary · PHP report · JS report

@annacmc annacmc force-pushed the add/new-chart-categorybar branch from 781cde2 to fec98a9 Compare December 4, 2025 04:53
@annacmc annacmc changed the title Charts: Add stacked bar chart support and CategoryBar component Charts: Add CategoryBar component Dec 4, 2025
@annacmc annacmc requested a review from Copilot December 4, 2025 05:33
Copilot finished reviewing on behalf of annacmc December 4, 2025 05:36

This comment was marked as outdated.

@annacmc annacmc changed the title Charts: Add CategoryBar component Charts: Add SegmentedBar component Dec 4, 2025
@annacmc annacmc requested a review from Copilot December 4, 2025 06:10
Copilot finished reviewing on behalf of annacmc December 4, 2025 06:14

This comment was marked as outdated.

@annacmc annacmc force-pushed the add/new-chart-categorybar branch from 7ba1591 to 136bfc1 Compare December 4, 2025 06:23
@annacmc annacmc marked this pull request as ready for review December 4, 2025 23:45
@annacmc annacmc requested review from a team, adamwoodnz and kangzj December 6, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[JS Package] Charts RNA [Status] In Progress [Status] Needs Review This PR is ready for review. [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants