Change how plugin perms are accessed

Author: edanzer

projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php

@@ -795,6 +795,8 @@ public static function load_editor_scripts() {
 				'assetsUrl'            => Jetpack_Forms::assets_url(),
 				'preferredView'        => $preferred_view,
 				'isMailPoetEnabled'    => Jetpack_Forms::is_mailpoet_enabled(),
+				'canInstallPlugins'    => current_user_can( 'install_plugins' ),
+				'canActivatePlugins'   => current_user_can( 'activate_plugins' ),
 			),
 		);
 

projects/packages/forms/src/blocks/contact-form/components/jetpack-integrations-modal/integration-card/plugin-action-button.tsx

@@ -2,13 +2,13 @@
  * External dependencies
  */
 import { Button, Spinner, Tooltip } from '@wordpress/components';
-import { store as coreStore } from '@wordpress/core-data';
-import { useSelect } from '@wordpress/data';
 import { __ } from '@wordpress/i18n';
 /**
  * Internal dependencies
  */
+import { config as dashboardConfig } from '../../../../../dashboard';
 import { usePluginInstallation } from '../hooks/use-plugin-installation';
+import type { JPFormsBlocksDefaults } from '../../../../../types';
 
 type PluginActionButtonProps = {
 	slug: string;
@@ -32,10 +32,14 @@ const PluginActionButton = ( {
 		trackEventName
 	);
 
+	// Permissions checks. We need to check both the editor-provided jpFormsBlocks
+	// and the dashboard config since this component loads in both places.
+	// In a future PR, we should consolidate this to a single source of truth.
+	const jpDefaults: JPFormsBlocksDefaults | undefined = window.jpFormsBlocks?.defaults;
 	const canUserInstallPlugins =
-		useSelect( select => select( coreStore ).canUser( 'create', 'plugins' ), [] ) ?? false;
+		Boolean( jpDefaults?.canInstallPlugins ) || Boolean( dashboardConfig( 'canInstallPlugins' ) );
 	const canUserActivatePlugins =
-		useSelect( select => select( coreStore ).canUser( 'update', 'plugins' ), [] ) ?? false;
+		Boolean( jpDefaults?.canActivatePlugins ) || Boolean( dashboardConfig( 'canActivatePlugins' ) );
 
 	const canPerformAction = isInstalled ? canUserActivatePlugins : canUserInstallPlugins;
 	const isDisabled = isInstalling || ! canPerformAction;

projects/packages/forms/src/dashboard/class-dashboard.php

@@ -230,6 +230,8 @@ public function render_dashboard( $extra_config = array() ) {
 			'renderMigrationPage'     => $this->switch->is_jetpack_forms_announcing_new_menu(),
 			'dashboardURL'            => add_query_arg( 'jetpack_forms_migration_announcement_seen', 'yes', $this->switch->get_forms_admin_url() ),
 			'isMailpoetEnabled'       => Jetpack_Forms::is_mailpoet_enabled(),
+			'canInstallPlugins'       => current_user_can( 'install_plugins' ),
+			'canActivatePlugins'      => current_user_can( 'activate_plugins' ),
 		);
 
 		if ( ! empty( $extra_config ) ) {

projects/packages/forms/src/types/index.ts

@@ -104,6 +104,10 @@ export interface JPFormsBlocksDefaults {
 	formsResponsesSpamUrl?: string;
 	/** Whether MailPoet integration is enabled. */
 	isMailPoetEnabled?: boolean;
+	/** Whether the current user can install plugins. */
+	canInstallPlugins?: boolean;
+	/** Whether the current user can activate plugins. */
+	canActivatePlugins?: boolean;
 }
 
 /**