Phan: Fix PhanTypeMismatchArgument violations (#45048)

Author: tbradsha

projects/packages/backup-helper-script-manager/.phan/baseline.php

@@ -10,13 +10,10 @@
 return [
     // # Issue statistics:
     // PhanTypeMismatchArgumentProbablyReal : 15+ occurrences
-    // PhanTypeMismatchArgumentInternal : 3 occurrences
-    // PhanTypeMismatchForeach : 2 occurrences
 
     // Currently, file_suppressions and directory_suppressions are the only supported suppressions
     'file_suppressions' => [
-        'src/class-helper-script-manager-impl.php' => ['PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchForeach'],
-        'tests/php/Throw_On_Errors_Test.php' => ['PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchArgumentProbablyReal'],
+        'tests/php/Throw_On_Errors_Test.php' => ['PhanTypeMismatchArgumentProbablyReal'],
     ],
     // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed.
     // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases)

projects/packages/backup-helper-script-manager/changelog/fix-phan-PhanTypeMismatchArgumentInternal

@@ -0,0 +1,5 @@
+Significance: patch
+Type: fixed
+Comment: Fix some PhanTypeMismatchArgument violations.
+
+

projects/packages/backup-helper-script-manager/src/class-throw-on-errors.php

@@ -328,7 +328,7 @@ function () use ( $directory, $permissions, $recursive ) {
 	 *
 	 * @param string $directory Directory that will be scanned.
 	 *
-	 * @return string An array of filenames.
+	 * @return string[] An array of filenames.
 	 * @throws Exception If scandir() has thrown warnings, or has failed.
 	 */
 	public static function t_scandir( $directory ) {

projects/packages/boost-core/.phan/baseline.php

@@ -10,12 +10,10 @@
 return [
     // # Issue statistics:
     // PhanAbstractStaticMethodCallInStatic : 3 occurrences
-    // PhanTypeMismatchArgumentInternal : 2 occurrences
 
     // Currently, file_suppressions and directory_suppressions are the only supported suppressions
     'file_suppressions' => [
         'src/lib/class-cacheable.php' => ['PhanAbstractStaticMethodCallInStatic'],
-        'src/lib/class-utils.php' => ['PhanTypeMismatchArgumentInternal'],
     ],
     // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed.
     // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases)

projects/packages/boost-core/changelog/fix-phan-PhanTypeMismatchArgumentInternal

@@ -0,0 +1,5 @@
+Significance: patch
+Type: fixed
+Comment: Fix some PhanTypeMismatchArgument violations.
+
+

projects/packages/boost-core/src/lib/class-utils.php

@@ -38,7 +38,7 @@ public static function standardize_error( $error ) {
 		if ( is_object( $error ) ) {
 			return array(
 				'name'    => 'Error',
-				'message' => json_decode( wp_json_encode( $error ), ARRAY_A ),
+				'message' => json_decode( wp_json_encode( $error ), true ),
 			);
 		}
 
@@ -124,7 +124,7 @@ public static function send_wpcom_request( $method, $endpoint, $args = null, $bo
 
 		// Check for HTTP errors.
 		$code = wp_remote_retrieve_response_code( $response );
-		$data = json_decode( wp_remote_retrieve_body( $response ), ARRAY_A );
+		$data = json_decode( wp_remote_retrieve_body( $response ), true );
 
 		if ( 200 !== $code ) {
 			$default_message = sprintf(

projects/packages/classic-theme-helper/.phan/baseline.php

@@ -9,7 +9,6 @@
  */
 return [
     // # Issue statistics:
-    // PhanTypeMismatchArgumentInternal : 10+ occurrences
     // PhanUndeclaredClassMethod : 10+ occurrences
     // PhanTypePossiblyInvalidDimOffset : 8 occurrences
     // PhanTypeSuspiciousNonTraversableForeach : 6 occurrences
@@ -22,7 +21,7 @@
 
     // Currently, file_suppressions and directory_suppressions are the only supported suppressions
     'file_suppressions' => [
-        '_inc/lib/tonesque.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchArgumentProbablyReal'],
+        '_inc/lib/tonesque.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentProbablyReal'],
         'src/class-featured-content.php' => ['PhanTypeInvalidDimOffset', 'PhanTypeMismatchArgument', 'PhanTypeMismatchProperty', 'PhanTypePossiblyInvalidDimOffset'],
         'src/class-social-links.php' => ['PhanUndeclaredClassMethod', 'PhanUndeclaredClassReference', 'PhanUndeclaredTypeProperty'],
         'src/content-options/featured-images-fallback.php' => ['PhanTypePossiblyInvalidDimOffset'],

projects/packages/classic-theme-helper/_inc/lib/tonesque.php

@@ -157,12 +157,12 @@ public function grab_points( $type = 'index' ) {
 			* Sample five points in the image
 			* based on rule of thirds and center.
 			*/
-			$topy    = round( $height / 3 );
-			$bottomy = round( ( $height / 3 ) * 2 );
-			$leftx   = round( $width / 3 );
-			$rightx  = round( ( $width / 3 ) * 2 );
-			$centery = round( $height / 2 );
-			$centerx = round( $width / 2 );
+			$topy    = (int) round( $height / 3 );
+			$bottomy = (int) round( ( $height / 3 ) * 2 );
+			$leftx   = (int) round( $width / 3 );
+			$rightx  = (int) round( ( $width / 3 ) * 2 );
+			$centery = (int) round( $height / 2 );
+			$centerx = (int) round( $width / 2 );
 
 			// Cast those colors into an array.
 			$points = array(

projects/packages/classic-theme-helper/changelog/fix-phan-PhanTypeMismatchArgumentInternal

@@ -0,0 +1,5 @@
+Significance: patch
+Type: fixed
+Comment: Fix some PhanTypeMismatchArgument violations.
+
+

projects/packages/connection/.phan/baseline.php

@@ -14,10 +14,9 @@
     // PhanTypeMismatchReturn : 15+ occurrences
     // PhanTypeMismatchPropertyProbablyReal : 9 occurrences
     // PhanTypeMismatchReturnProbablyReal : 8 occurrences
-    // PhanTypeMismatchArgumentProbablyReal : 7 occurrences
     // PhanTypeArraySuspiciousNullable : 5 occurrences
     // PhanTypeMismatchDefault : 4 occurrences
-    // PhanTypeMismatchArgumentInternal : 3 occurrences
+    // PhanTypeMismatchArgumentProbablyReal : 3 occurrences
     // PhanTypeObjectUnsetDeclaredProperty : 3 occurrences
     // PhanDeprecatedFunction : 2 occurrences
     // PhanNonClassMethodCall : 2 occurrences
@@ -36,7 +35,7 @@
     // Currently, file_suppressions and directory_suppressions are the only supported suppressions
     'file_suppressions' => [
         'legacy/class-jetpack-options.php' => ['PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchArgumentProbablyReal'],
-        'legacy/class-jetpack-signature.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchArgumentInternal'],
+        'legacy/class-jetpack-signature.php' => ['PhanPluginDuplicateConditionalNullCoalescing'],
         'legacy/class-jetpack-tracks-client.php' => ['PhanNonClassMethodCall', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchArgument', 'PhanTypeMismatchPropertyProbablyReal'],
         'legacy/class-jetpack-xmlrpc-server.php' => ['PhanAccessMethodInternal', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchDefault', 'PhanTypeMismatchReturn'],
         'src/class-error-handler.php' => ['PhanTypeMismatchReturnProbablyReal'],
@@ -49,7 +48,7 @@
         'src/class-rest-connector.php' => ['PhanTypeMismatchArgument', 'PhanTypeMismatchReturnProbablyReal'],
         'src/class-secrets.php' => ['PhanNonClassMethodCall', 'PhanTypeMismatchArgument'],
         'src/class-server-sandbox.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchArgument'],
-        'src/class-tokens.php' => ['PhanTypeMismatchArgumentInternal', 'PhanTypeMismatchReturn', 'PhanTypeMismatchReturnProbablyReal'],
+        'src/class-tokens.php' => ['PhanTypeMismatchReturn', 'PhanTypeMismatchReturnProbablyReal'],
         'src/class-tracking.php' => ['PhanPluginDuplicateConditionalNullCoalescing', 'PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMismatchDefault', 'PhanTypePossiblyInvalidDimOffset'],
         'src/sso/class-sso.php' => ['PhanTypeMismatchArgument'],
         'src/sso/class-user-admin.php' => ['PhanPluginUnreachableCode', 'PhanTypeMismatchArgument'],
@@ -61,7 +60,6 @@
         'tests/php/REST_Authentication_Test.php' => ['PhanTypeMismatchArgument'],
         'tests/php/REST_Endpoints_Test.php' => ['PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMismatchReturn', 'PhanTypeMismatchReturnProbablyReal'],
         'tests/php/Server_Sandbox_Test.php' => ['PhanTypeArraySuspiciousNullable'],
-        'tests/php/SignatureTest.php' => ['PhanTypeMismatchArgumentProbablyReal'],
         'tests/php/TokensTest.php' => ['PhanTypeObjectUnsetDeclaredProperty'],
     ],
     // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed.