test__author_queried_object_fix doesn't need to initialise wp_rewrite

[SeanDS]

The test test__author_queried_object_fix doesn't need to use wp_rewrite. It passes without it. What does it even have to do with the feature being tested?

[TheCrowned]

test__author_queried_object_fix() calls get_author_posts_url(), which uses $wp_rewrite to do $link = $wp_rewrite->get_author_permastruct();, so I guess that is why $wp_rewrite is being initialized.

Are you sure it should be removed? Aren't there situations in which it may not be already initialized, and get to get_author_posts_url() still un-initialized? This would be a problem, as get_author_posts_url() doesn't even check that it is correctly setup but just assumes it.

[SeanDS]

I didn't look into this too deeply, so it might be that it is needed in some edge cases, but the initialisation of $wp_rewrite sounds like it should be done in WordPress's testing initialisation code. I'd be surprised if this wasn't already initialised somewhere prior to the unit test being run.