Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Commit 4e7df7c

Browse files
authored
Merge pull request #49 from AssemblyAI/niels/fix-useragent-conflict
Fix UserAgent conflict
2 parents 02e185b + 78cb80d commit 4e7df7c

File tree

7 files changed

+20
-16
lines changed

7 files changed

+20
-16
lines changed

.fernignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ assemblyai.gemspec
1111

1212
lib/gemconfig.rb
1313
lib/requests.rb
14-
lib/user_agent.rb
1514
lib/assemblyai.rb
15+
lib/assemblyai/types/user_agent.rb
1616

1717
<!-- Manual customized files client -->
1818
lib/assemblyai/files/client.rb

lib/assemblyai.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
require_relative "environment"
44
require_relative "types_export"
55
require_relative "requests"
6+
require_relative "assemblyai/types/user_agent"
67
require_relative "assemblyai/files/client"
78
require_relative "assemblyai/transcripts/client"
89
require_relative "assemblyai/transcripts/polling_client"

lib/user_agent.rb renamed to lib/assemblyai/types/user_agent.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def add_item(key, user_agent_item)
3333
# @param user_agent2 [AssemblyAI::UserAgent]
3434
# @return [AssemblyAI::UserAgent]
3535
def self.merge(user_agent1, user_agent2)
36-
merged_user_agent = UserAgent.new
36+
merged_user_agent = AssemblyAI::UserAgent.new
3737

3838
user_agent1&.user_agent_items&.each do |key, item|
3939
merged_user_agent.add_item(key, item)
@@ -62,8 +62,8 @@ class DefaultUserAgent
6262
attr_reader :user_agent
6363

6464
def initialize
65-
@user_agent = UserAgent.new
66-
@user_agent.add_item("sdk", UserAgentItem.new(name: "Ruby", version: AssemblyAI::Gemconfig::VERSION))
65+
@user_agent = AssemblyAI::UserAgent.new
66+
@user_agent.add_item("sdk", AssemblyAI::UserAgentItem.new(name: "Ruby", version: AssemblyAI::Gemconfig::VERSION))
6767
end
6868
end
6969
end

lib/gemconfig.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
module AssemblyAI
44
module Gemconfig
5-
VERSION = "1.0.0"
5+
VERSION = "1.0.1"
66
AUTHORS = ["AssemblyAI"].freeze
77
88
SUMMARY = "AssemblyAI Ruby SDK"

lib/requests.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22

33
require_relative "environment"
4-
require_relative "user_agent"
4+
require_relative "assemblyai/types/user_agent"
55
require_relative "gemconfig"
66
require "faraday"
77
require "faraday/retry"

lib/types_export.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,3 +85,4 @@
8585
require_relative "assemblyai/lemur/types/lemur_model"
8686
require_relative "assemblyai/lemur/types/lemur_usage"
8787
require_relative "assemblyai/types/error"
88+
require_relative "assemblyai/types/user_agent"

test/test_assemblyai.rb

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,18 @@ def api_key
1111
ENV.fetch("ASSEMBLYAI_API_KEY")
1212
end
1313

14+
# @return [String] AssemblyAI Base URL
15+
def base_url
16+
ENV.key?("ASSEMBLYAI_BASE_URL") ? ENV.fetch("ASSEMBLYAI_BASE_URL") : AssemblyAI::Environment::DEFAULT
17+
end
18+
19+
def client
20+
AssemblyAI::Client.new(
21+
api_key: api_key,
22+
environment: base_url
23+
)
24+
end
25+
1426
# @return [String] Transcript ID
1527
def transcript_id
1628
ENV.fetch("TEST_TRANSCRIPT_ID")
@@ -22,20 +34,17 @@ def transcript_ids
2234
end
2335

2436
def test_upload_file_with_file
25-
client = AssemblyAI::Client.new(api_key: api_key)
2637
file = File.new("./test/gore-short.wav")
2738
uploaded_file = client.files.upload(file: file)
2839
assert !uploaded_file.upload_url.nil?
2940
end
3041

3142
def test_upload_file_with_path
32-
client = AssemblyAI::Client.new(api_key: api_key)
3343
uploaded_file = client.files.upload(file: "./test/gore-short.wav")
3444
assert !uploaded_file.upload_url.nil?
3545
end
3646

3747
def test_upload_file_with_base64_string
38-
client = AssemblyAI::Client.new(api_key: api_key)
3948
uploaded_file = client.files.upload(file: File.read("./test/gore-short.wav"))
4049
assert !uploaded_file.upload_url.nil?
4150
end
@@ -46,7 +55,6 @@ def test_init
4655
end
4756

4857
def test_pagination
49-
client = AssemblyAI::Client.new(api_key: api_key)
5058
transcript_list = client.transcripts.list
5159

5260
count = 0
@@ -69,24 +77,19 @@ def test_pagination
6977
end
7078

7179
def test_transcribe
72-
client = AssemblyAI::Client.new(api_key: api_key)
7380
transcript = client.transcripts.transcribe(audio_url: "https://storage.googleapis.com/aai-web-samples/espn-bears.m4a")
7481
assert transcript.status == AssemblyAI::Transcripts::TranscriptStatus::COMPLETED
7582
end
7683

7784
def test_submit
7885
# Transcribe
79-
client = AssemblyAI::Client.new(api_key: api_key)
80-
8186
transcript_submission = client.transcripts.submit(audio_url: "https://storage.googleapis.com/aai-web-samples/espn-bears.m4a")
8287
assert !transcript_submission.id.nil?
8388
gotten_transcript = client.transcripts.get(transcript_id: transcript_submission.id)
8489
assert gotten_transcript.id == transcript_submission.id
8590
end
8691

8792
def test_polling
88-
client = AssemblyAI::Client.new(api_key: api_key)
89-
9093
transcript = client.transcripts.submit(audio_url: "https://storage.googleapis.com/aai-web-samples/espn-bears.m4a")
9194
assert !transcript.id.nil?
9295

@@ -95,7 +98,6 @@ def test_polling
9598
end
9699

97100
def test_lemur
98-
client = AssemblyAI::Client.new(api_key: api_key)
99101
assert !client.lemur.summary(transcript_ids: transcript_ids).response.nil?
100102

101103
qa_response = client.lemur.question_answer(

0 commit comments

Comments
 (0)