Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Commit 1c156e7

Browse files
authored
Sync from internal repo (2024-03-28) (#16)
* fix(sdk/go): add value for best model (#4271) GitOrigin-RevId: ec5933105be3087e768e6c0e6d0ba6f311635017 * fix(sdk/go): fix missing api key (#4292) GitOrigin-RevId: dfd3bf62746e889aeaff801cd26d4311eadab327 * refactor(sdk/go): use testify for all tests (#4302) GitOrigin-RevId: add14f866d3655d36848f3a84dd5b8bfec8830b4
1 parent 4f91eb8 commit 1c156e7

File tree

11 files changed

+183
-216
lines changed

11 files changed

+183
-216
lines changed

assemblyai.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
)
1212

1313
const (
14-
version = "1.4.0"
14+
version = "1.4.1"
1515
defaultBaseURLScheme = "https"
1616
defaultBaseURLHost = "api.assemblyai.com"
1717
defaultUserAgent = "assemblyai-go/" + version

assemblyai_test.go

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import (
55
"net/http/httptest"
66
"os"
77
"testing"
8+
9+
"github.com/stretchr/testify/require"
810
)
911

1012
func setup() (*Client, *http.ServeMux, func()) {
@@ -17,29 +19,12 @@ func setup() (*Client, *http.ServeMux, func()) {
1719
return client, handler, server.Close
1820
}
1921

20-
func testMethod(t *testing.T, r *http.Request, want string) {
21-
t.Helper()
22-
23-
if r.Method != want {
24-
t.Errorf("Request method = %v, want = %v", r.Method, want)
25-
}
26-
}
27-
28-
func testQuery(t *testing.T, r *http.Request, want string) {
29-
t.Helper()
30-
31-
if r.URL.RawQuery != want {
32-
t.Errorf("Request query = %v, want = %v", r.URL.RawQuery, want)
33-
}
34-
}
35-
3622
func writeFileResponse(t *testing.T, w http.ResponseWriter, filename string) {
3723
t.Helper()
3824

3925
b, err := os.ReadFile(filename)
40-
if err != nil {
41-
t.Errorf("ReadFile returned error: %v", err)
42-
}
26+
require.NoError(t, err)
4327

44-
w.Write(b)
28+
_, err = w.Write(b)
29+
require.NoError(t, err)
4530
}

examples/realtime/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/AssemblyAI/DeepLearning/assemblyai/developer_tools/go/examples
33
go 1.18
44

55
require (
6-
github.com/AssemblyAI/assemblyai-go-sdk v1.1.0
6+
github.com/AssemblyAI/assemblyai-go-sdk v1.3.0
77
github.com/gordonklaus/portaudio v0.0.0-20230709114228-aafa478834f5
88
)
99

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ go 1.18
44

55
require (
66
github.com/cenkalti/backoff v2.2.1+incompatible
7-
github.com/google/go-cmp v0.5.9
87
github.com/google/go-querystring v1.1.0
98
github.com/stretchr/testify v1.9.0
109
nhooyr.io/websocket v1.8.7
1110
)
1211

1312
require (
1413
github.com/davecgh/go-spew v1.1.1 // indirect
14+
github.com/google/go-cmp v0.5.9 // indirect
1515
github.com/klauspost/compress v1.10.3 // indirect
1616
github.com/pmezard/go-difflib v1.0.0 // indirect
1717
gopkg.in/yaml.v3 v3.0.1 // indirect

integration_test.go

Lines changed: 14 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -2,38 +2,19 @@ package assemblyai
22

33
import (
44
"context"
5-
"flag"
6-
"fmt"
75
"os"
86
"testing"
9-
)
107

11-
var (
12-
integration = flag.Bool("integration", false, "Enable integration tests.")
13-
apiKey = os.Getenv("ASSEMBLYAI_API_KEY")
8+
"github.com/stretchr/testify/require"
149
)
1510

16-
func TestMain(m *testing.M) {
17-
flag.Parse()
18-
19-
if *integration && apiKey == "" {
20-
fmt.Println("missing api key")
21-
os.Exit(1)
22-
}
23-
24-
os.Exit(m.Run())
25-
}
26-
27-
func isIntegration(t *testing.T) {
28-
t.Helper()
11+
func TestIntegration(t *testing.T) {
12+
t.Parallel()
2913

30-
if !*integration {
31-
t.Skip("skipping integration test...")
14+
apiKey := os.Getenv("ASSEMBLYAI_API_KEY")
15+
if apiKey == "" {
16+
t.Skip("ASSEMBLYAI_API_KEY not set")
3217
}
33-
}
34-
35-
func TestIntegration(t *testing.T) {
36-
isIntegration(t)
3718

3819
client := NewClient(apiKey)
3920

@@ -43,45 +24,31 @@ func TestIntegration(t *testing.T) {
4324

4425
// Transcript
4526
f, err := os.Open(path)
46-
if err != nil {
47-
t.Fatalf("os.Open returned error: %v", err)
48-
}
27+
require.NoError(t, err)
4928
defer f.Close()
5029

5130
t.Logf("uploading %q...", path)
5231

5332
audioURL, err := client.Upload(ctx, f)
54-
if err != nil {
55-
t.Fatalf("Upload returned error: %v", err)
56-
}
33+
require.NoError(t, err)
5734

5835
t.Log("uploaded file")
5936
t.Logf("submitting %q...", audioURL)
6037

6138
transcript, err := client.Transcripts.SubmitFromURL(ctx, audioURL, nil)
62-
if err != nil {
63-
t.Fatalf("Transcripts.Submit returned error: %v", err)
64-
}
39+
require.NoError(t, err)
6540

66-
if transcript.Status != TranscriptStatusQueued {
67-
t.Fatalf("transcript.Status = %v, want %v", transcript.Status, err)
68-
}
41+
require.Equal(t, TranscriptStatusQueued, transcript.Status)
6942

7043
t.Log("submitted transcription")
7144
t.Log("waiting for transcription...")
7245

7346
transcript, err = client.Transcripts.Wait(ctx, ToString(transcript.ID))
74-
if err != nil {
75-
t.Fatalf("Transcripts.Wait returned error: %v", err)
76-
}
47+
require.NoError(t, err)
7748

78-
if transcript.Status != TranscriptStatusCompleted {
79-
t.Errorf("transcript.Status = %v, want %v", transcript.Status, err)
80-
}
49+
require.Equal(t, TranscriptStatusCompleted, transcript.Status)
8150

82-
if *transcript.Text == "" {
83-
t.Errorf("transcript is missing text")
84-
}
51+
require.NotEmpty(t, *transcript.Text)
8552

8653
t.Log("completed transcription")
8754
t.Logf("transcript.Text = %v", ToString(transcript.Text))
@@ -95,9 +62,7 @@ func TestIntegration(t *testing.T) {
9562
TranscriptIDs: []string{ToString(transcript.ID)},
9663
},
9764
})
98-
if err != nil {
99-
t.Fatalf("LeMUR.Summarize returned error: %v", err)
100-
}
65+
require.NoError(t, err)
10166

10267
t.Logf("LeMUR.Summarize = %v", ToString(response.Response))
10368
}

0 commit comments

Comments
 (0)