-
-
Notifications
You must be signed in to change notification settings - Fork 495
lane_data: Adding lane data module to assist in getting filament loaded in filament changers #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jim Madill <[email protected]>
Signed-off-by: Jim Madill <[email protected]>
|
Thanks. Before I get into a detailed review, have you considered using the Database APIs to store and retrieve this data? There is really no need for an additional component to perform this task, and an additional benefit is that the data is persistent across restarts. |
Good point, this did not originally cross my mind when we were discussing this. |
|
Guess the only real upside to this module is that there will be a documented API that holds a common structure so third-parties know what information is available to pull down and use, and other klipper addons/plugins know what information to push up. |
|
The documentation could be added to the AFC project directly. Presumably developers would need to refer to it for other information if they want to integrate support for AFC in their front-end and/or slicer. The Database APIs were created for persistent data storage and information sharing between clients, so at this time I believe that the best approach would be to use them. The database is used in a similar fashion to store common webcam data used by clients. Later it was necessary to add a component wrapping the stored data, as we wanted to extend functionality such as adding webcams in |
We can do this for now, we were just trying to push something out there that was not necessarily tied just to AFC-Klipper-Add-On. |
|
Perhaps we can provide some documentation in Moonraker for 3rd party namespaces, including specifications for the structure. |
This is another feature requested by AJAX3D to aid in a common API for filament changers so that third-parties like slicers can fetch data about what is loaded and automatically use this data when slicing. AJAX3D has been in talks with Softfever to add this fetch functionality into OrcaSlicer.
This has been tested by multiple testers in a development branch of AFC-Klipper-Add-On.
Signed-off-by: Jim Madill [email protected]