fix(error context generation): bad context generation could sometimes happen if an invalid node is found and is on more than one line

SuperFola · SuperFola · commit 58a637f4721b · 2025-06-02T20:01:35.000+02:00
diff --git a/src/arkreactor/Exceptions.cpp b/src/arkreactor/Exceptions.cpp
@@ -195,7 +195,7 @@ namespace Ark::Diagnostics
         show_file_location();
         LineColorContextCounts line_color_context_counts;
 
-        for (auto i = first_line; i < last_line; ++i)
+        for (auto i = first_line; i < last_line && i < lines.size(); ++i)
         {
             if (i >= start_line_skipping_at && i < stop_line_skipping_at)
                 continue;
diff --git a/tests/unittests/resources/DiagnosticsSuite/compileTime/invalid_node_multilines.ark b/tests/unittests/resources/DiagnosticsSuite/compileTime/invalid_node_multilines.ark
@@ -0,0 +1,3 @@
+000000000080000000000000
+80000000000000000
+(
diff --git a/tests/unittests/resources/DiagnosticsSuite/compileTime/invalid_node_multilines.expected b/tests/unittests/resources/DiagnosticsSuite/compileTime/invalid_node_multilines.expected
@@ -0,0 +1,9 @@
+At 0 @ 1:1
+    1 | 000000000080000000000000
+      | ^~~~~~~~~~~~~~~~~~~~~~~
+    2 | 80000000000000000
+      | ^~~~~~~~~~~~~~~~
+    3 | (
+      | ^
+    4 |
+        invalid syntax, expected node

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ namespace Ark::Diagnostics`
`195`	`195`	`show_file_location();`
`196`	`196`	`LineColorContextCounts line_color_context_counts;`
`197`	`197`
`198`		`- for (auto i = first_line; i < last_line; ++i)`
	`198`	`+ for (auto i = first_line; i < last_line && i < lines.size(); ++i)`
`199`	`199`	`{`
`200`	`200`	`if (i >= start_line_skipping_at && i < stop_line_skipping_at)`
`201`	`201`	`continue;`