Skip to content

Commit 629d7ef

Browse files
committed
fix backup for azblob disk behavior when storage_account_url contains container as first part in hostname
Signed-off-by: Slach <[email protected]>
1 parent c61db37 commit 629d7ef

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ BUG FIXES
33
- fix `clickhouse_backup_number_backups_remote` and `last_backup_size_remote` metrics behavior in `watch` command, fix [1152](https://github.com/Altinity/clickhouse-backup/issues/1152)
44
- fix empty `path` and non-empty `object_disk_path` config parameters, allows unexpected deletion backup object disk data, fix [859](https://github.com/Altinity/clickhouse-backup/issues/859)
55
- reproduce behavior `<metadata_path>` parameter in clickhouse `<storage_configuration>` don't contain trailing slash, restore make hardlinks to wrong directory, look details in https://github.com/Altinity/clickhouse-backup/issues/859#issuecomment-2896880448, https://github.com/ClickHouse/ClickHouse/issues/80647
6+
- fix backup for azblob disk behavior when `storage_account_url` contains container as first part in hostname
67

78
# v2.6.18
89
IMPROVEMENTS

pkg/storage/object_disk/object_disk.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,7 @@ func makeObjectDiskConnection(ctx context.Context, ch *clickhouse.ClickHouse, cf
587587
azureCfg.EndpointSuffix = azureURL.Host
588588
if creds.AzureAccountName != "" {
589589
azureCfg.AccountName = creds.AzureAccountName
590+
azureCfg.EndpointSuffix = strings.TrimPrefix(azureCfg.EndpointSuffix, azureCfg.AccountName+".")
590591
}
591592
if azureURL.Path != "" {
592593
azureCfg.Path = azureURL.Path

0 commit comments

Comments
 (0)