Skip to content

Commit 1696d2f

Browse files
committed
Namespaced tooltips (Lchiffon#18 with help from Lchiffon#29) and removed extraneous console statements
1 parent a202fe9 commit 1696d2f

File tree

4 files changed

+21
-33
lines changed

4 files changed

+21
-33
lines changed

.gitignore

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
.Rproj.user
2-
.Rhistory
3-
.RData
4-
wordcloud2.Rproj
1+
.Rproj.user
2+
.Rhistory
3+
.RData
4+
wordcloud2.Rproj
5+
.DS_Store

R/wordcloud2.R

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ wordcloud2 <- function(data,
149149
)
150150

151151

152-
chart = htmlwidgets::createWidget("wordcloud2", settings,
152+
htmlwidgets::createWidget("wordcloud2", settings,
153153
width = widgetsize[1],
154154
height = widgetsize[2],
155155
sizingPolicy = htmlwidgets::sizingPolicy(
@@ -158,16 +158,6 @@ wordcloud2 <- function(data,
158158
browser.padding = 0,
159159
browser.fill = TRUE
160160
))
161-
162-
163-
htmlwidgets::onRender(chart,"function(el,x){
164-
console.log(123);
165-
if(!iii){
166-
window.location.reload();
167-
iii = False;
168-
169-
}
170-
}")
171161
}
172162

173163

inst/htmlwidgets/lib/wordcloud2-0.0.1/hover.js

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,47 +2,48 @@
22
function newlabel(el){
33
var newDiv = document.createElement("div");
44
var newSpan = document.createElement("span");
5-
newDiv.id = 'wcLabel';
6-
newSpan.id = "wcSpan";
5+
var id = el.id
6+
newDiv.id = id + "wcLabel";
7+
newDiv.className += "wcLabel";
8+
newSpan.id = id + "wcSpan";
9+
newSpan.className += "wcSpan";
710
el.appendChild(newDiv);
8-
document.getElementById("wcLabel").appendChild(newSpan);
11+
document.getElementById(id + "wcLabel").appendChild(newSpan);
912
}
1013

1114
// hover function
1215
function cv_handleHover(item, dimension, evt) {
13-
var el = document.getElementById("wcLabel");
16+
var id = evt.path[1].id
17+
var el = document.getElementById(id + "wcLabel");
18+
var target = evt.target || evt.srcElement;
1419
if (!item) {
1520
el.setAttribute('hidden', true);
1621

1722
return;
1823
}
1924

2025
el.removeAttribute('hidden');
21-
// console.log(evt.srcElement.offsetLeft);
2226

23-
el.style.left = dimension.x + evt.srcElement.offsetLeft + 'px';
24-
el.style.top = dimension.y + evt.srcElement.offsetTop + 'px';
27+
el.style.left = dimension.x + target.offsetLeft + 'px';
28+
el.style.top = dimension.y + target.offsetTop + 'px';
2529
el.style.width = dimension.w + 'px';
2630
el.style.height = dimension.h + 'px';
2731

2832
this.hoverDimension = dimension;
2933

30-
document.getElementById("wcSpan").setAttribute(
34+
document.getElementById(id + "wcSpan").setAttribute(
3135
'data-l10n-args', JSON.stringify({ word: item[0], count: item[1] }));
32-
document.getElementById("wcSpan").innerHTML =item[0]+":" + item[1];
36+
document.getElementById(id + "wcSpan").innerHTML =item[0]+":" + item[1];
3337

3438
}
3539

3640
//mask function
3741
function maskInit(el,x){
38-
console.log(1)
3942
str = x.figBase64;
40-
//console.log(str)
4143
var newImg = new Image();
4244
newImg.src = str;
4345
newImg.style.position = 'absolute';
4446
newImg.style.left = 0;
45-
// console.log(el.clientHeight);
4647
newImg.width = el.clientWidth;
4748
newImg.height = el.clientHeight;
4849
// maskCanvas = init(el, x, newImg);
@@ -55,7 +56,6 @@ function maskInit(el,x){
5556
var imageData = ctx.getImageData(0, 0, maskCanvas.width, maskCanvas.height);
5657
var newImageData = ctx.createImageData(imageData);
5758
// M = 0
58-
console.log(imageData.data.length);
5959
for (var i = 0; i < imageData.data.length; i += 4) {
6060
var tone = imageData.data[i] +
6161
imageData.data[i + 1] +
@@ -84,12 +84,10 @@ function maskInit(el,x){
8484
bctx.fillStyle = x.backgroundColor || '#fff';
8585
bctx.fillRect(0, 0, 1, 1);
8686
var bgPixel = bctx.getImageData(0, 0, 1, 1).data;
87-
console.log(bgPixel);
8887
var maskCanvasScaled = document.createElement('canvas');
8988
maskCanvasScaled.width = el.clientWidth;
9089
maskCanvasScaled.height = el.clientHeight;
9190
ctx = maskCanvasScaled.getContext('2d');
92-
console.log(maskCanvasScaled);
9391
ctx.drawImage(maskCanvas,
9492
0, 0, maskCanvas.width, maskCanvas.height);
9593

@@ -136,4 +134,3 @@ function maskInit(el,x){
136134
abortThreshold: 3000
137135
});
138136
}
139-

inst/htmlwidgets/lib/wordcloud2-0.0.1/wordcloud.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11

2-
#wcLabel {
2+
.wcLabel {
33
position: absolute;
44
border: 2px solid #fff;
55
box-shadow: 0 0 4px 0 #008;
66
padding: 2px;
77
/*margin: -4px 0 0 -4px;*/
88
pointer-events: none; }
99

10-
#wcSpan {
10+
.wcSpan {
1111
position: absolute;
1212
top: 100%;
1313
left: 0;

0 commit comments

Comments
 (0)