Finished stacks questions and tests passing, updated methods

Author: criacuervos

lib/queue.rb

@@ -6,29 +6,33 @@ def initialize
   end
 
   def enqueue(element)
+    #Circular buffer method
     #Check if queue is empty
     if @front == -1 && @back == -1
       @front = 0
       @back = 0
     end 
+
     #Check if queue is full
     if ((@back + 1) % @store.length) == @front
-      raise ArgumentError.new("Error: queue is full")
+      raise ArgumentError.new("Queue is full!")
     end
 
     @store[@back] = element
-    #Make it wrap around when it reaches the end & do the modulo to not go over the end of the array
+    #Make it wrap around when it reaches the end & use modulo to not go over the end
     @back = (@back + 1) % @store.length
   end
 
   def dequeue
-    # when queue is empty
     if @front == @back
-      raise ArgumentError.new("Error: queue is empty")
+      raise ArgumentError.new("Queue is empty!")
     end
 
+    #Store the current first element in a temp
     temp = @store[@front]
+    #Make the front element nil 
     @store[@front] = nil
+
     @front = (@front + 1) % @store.length
 
     return temp

lib/stack.rb

@@ -1,28 +1,23 @@
+require_relative './linked_list.rb'
+
 class Stack
   def initialize
-    @store = Array.new(10)
-    @front = -1
-    @back = -1
+    @store = LinkedList.new
   end
 
   def push(element)
-    #if top position is the last of position of stack, means stack is full .
-    if @front == @store.length - 1
-      raise ArgumentError.new("Stack is full, overflow condition!")
-    else 
-      #Increment top position
-      @front = @front + 1;
-      #Insert element on the incremented position 
-      @store[@front] = element 
-    end 
+    @store.add_last(element)
+    return @store
   end
 
   def pop
-    raise NotImplementedError, "Not yet implemented"
+    return @store.remove_last if @store.get_first != nil 
   end
 
   def empty?
-    raise NotImplementedError, "Not yet implemented"
+    if @store.get_first == nil
+      return true 
+    end
   end
 
   def to_s

test/stack_test.rb

@@ -16,7 +16,6 @@
   end
 
   it "pushes multiple somethings onto a Stack" do
-    skip
     s = Stack.new
     s.push(10)
     s.push(20)
@@ -25,13 +24,11 @@
   end
 
   it "starts the stack empty" do
-    skip
     s = Stack.new
     s.empty?.must_equal true
   end
 
   it "removes something from the stack" do
-    skip
     s = Stack.new
     s.push(5)
     removed = s.pop
@@ -40,7 +37,6 @@
   end
 
   it "removes the right something (LIFO)" do
-    skip
     s = Stack.new
     s.push(5)
     s.push(3)