Skip to content

Leaves -- Janice #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Leaves -- Janice #25

wants to merge 18 commits into from

Conversation

@jaitch
Copy link

@jaitch jaitch commented Dec 13, 2019

Exquisite React

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How did this project differ from in-class examples? There was more fun logic in changing up the displays. Props were passed to siblings.
How was this project similar to in-class examples? The form with fields, callback functions, passing of props.
If you had time to refactor one part of this project, what would you do to make it better? I'd really like to try the optional enhancements. Maybe think some more about what kind of conditional tools to use where and when and why.

@janicewhuang
get started, add more input fields
3ec925c
@janicewhuang
fixed typo in player submission form css file
4b8734d
@janicewhuang
work on callback function for form
313c7a1
@janicewhuang
get to working state, words going back up to Game component and joining
9d0d0de
@janicewhuang
sentence forming successfully
0960b46
@janicewhuang
start to fix player count
9e77bc8
@janicewhuang
move playercount functionality to form
bef22ff
@janicewhuang
whole poem collection working
b8efaa0
@janicewhuang
poem displaying as one line so next experiment with storing as array …
a28454d 
…of strings instead of string with newlines/breaks
@janicewhuang
poem array push now working; need to map formatted poem then return i…
41379ae 
…n final poem component
@janicewhuang
finally get final poem to render on individual lines
b29e320
@janicewhuang
add box color switch styling
d55a982
@janicewhuang
start wave three logic
69fd78a
@janicewhuang
added some conditionals, final poem button not showing when it should
c29b558
@janicewhuang
have final poem display and button alternation working
634c561
@janicewhuang
recent submission display working
bced2be
@janicewhuang
clean up whitespace
68b5f84
@janicewhuang
add proptypes
fdeda37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaitch @janicewhuang