#629 Fix PR suggestions and limit stack trace lengths of suppressed exceptions.

Author: yruslan

pramen/core/src/main/scala/za/co/absa/pramen/core/metastore/peristence/MetastorePersistenceIceberg.scala

@@ -112,7 +112,11 @@ class MetastorePersistenceIceberg(table: CatalogTable,
 
   def getExistingTable(catalogTable: CatalogTable)(implicit spark: SparkSession): Option[DataFrame] = {
     try {
-      Option(spark.read.table(catalogTable.getFullTableName))
+      val df = spark.table(catalogTable.getFullTableName)
+      // Force analysis to surface TABLE_OR_VIEW_NOT_FOUND at this point.
+      // Technically, not needed, but Spark can potentially skip analysis until the schema is requested.
+      val _ = df.schema
+      Some(df)
     } catch {
       // This is a common error
       case ex: AnalysisException if ex.getMessage().contains("Table or view not found") || ex.getMessage().contains("TABLE_OR_VIEW_NOT_FOUND") =>

pramen/core/src/main/scala/za/co/absa/pramen/core/utils/StringUtils.scala

@@ -174,19 +174,31 @@ object StringUtils {
   }
 
   /** Renders an exception as a string */
-  def renderThrowable(ex: Throwable, level: Int = 1, maximumLength: Option[Int] = None, escapeHTML: Boolean = false): String = {
+  def renderThrowable(ex: Throwable, level: Int = 1, maximumLength: Option[Int] = None, escapeHTML: Boolean = false, maxStackDepth: Int = 256): String = {
     val prefix = " " * (level * 2)
+
+    def renderStack(stack: Array[StackTraceElement]): String = {
+      if (stack.length > maxStackDepth) {
+        val stackSte = stack.take(maxStackDepth).map(s => s"$prefix$s").mkString("", EOL, EOL)
+        val more = stack.length - maxStackDepth
+        s"$stackSte$prefix... $more more\n"
+
+      } else {
+        stack.map(s => s"$prefix$s").mkString("", EOL, EOL)
+      }
+    }
+
     val errMsg = if (escapeHTML) StringUtils.escapeHTML(ex.toString) else ex.toString
-    val base = s"""$errMsg\n${ex.getStackTrace.map(s => s"$prefix$s").mkString("", EOL, EOL)}"""
+    val base = s"""$errMsg\n${renderStack(ex.getStackTrace)}"""
 
     val suppressed =
       if (ex.getSuppressed.nonEmpty && level < 6)
-        ex.getSuppressed.map(s => s"\n${prefix}Suppressed: " + renderThrowable(s, level + 1)).mkString
+        ex.getSuppressed.map(s => s"\n${prefix}Suppressed: " + renderThrowable(s, level + 1, maxStackDepth = 5)).mkString
       else
         ""
 
     val cause = Option(ex.getCause) match {
-      case Some(c) if level < 6 => s"\n${prefix}Caused by " + renderThrowable(c, level + 1)
+      case Some(c) if level < 6 => s"\n${prefix}Caused by " + renderThrowable(c, level + 1, None, escapeHTML = false, maxStackDepth)
       case _ => ""
     }
 

pramen/core/src/test/scala/za/co/absa/pramen/core/tests/utils/StringUtilsSuite.scala

@@ -224,8 +224,6 @@ class StringUtilsSuite extends AnyWordSpec {
       ex.addSuppressed(new IllegalStateException("suppress_root"))
       val s = renderThrowable(ex)
 
-      println(s)
-
       assert(s.contains("java.lang.RuntimeException: test"))
       assert(s.contains("  Suppressed: java.lang.IllegalStateException: suppress_root"))
       assert(s.contains("  Caused by java.lang.RuntimeException: cause"))